[GitHub] spark pull request: [SPARK-4650][SQL] Supporting multi column supp...

[marmbrus <gi...@git.apache.org>]

Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3511#discussion_r21120665
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ---
    @@ -992,4 +992,11 @@ class SQLQuerySuite extends QueryTest with BeforeAndAfterAll {
           "nulldata2 on nulldata1.value <=> nulldata2.value"),
             (1 to 2).map(i => Seq(i)))
       }
    +
    +  test("Supporting multi column support for count(distinct ..) function in Spark SQL") {
    --- End diff --
    
    Nit: I think this can just be `Multi-column COUNT(DISTINCT ...)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org