You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/05 17:29:10 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #13887: test: Adds tests to the filter scope components
michael-s-molina opened a new pull request #13887:
URL: https://github.com/apache/superset/pull/13887
### SUMMARY
Adds tests to the filter scope components.
### TEST PLAN
1 - Execute filter scope tests.
2 - All tests should pass.
@rusackas @junlincc
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #13887:
URL: https://github.com/apache/superset/pull/13887#discussion_r605858382
##########
File path: superset-frontend/src/dashboard/components/filterscope/FilterScope.test.tsx
##########
@@ -0,0 +1,372 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import FilterScopeSelector from './FilterScopeSelector';
+
+const ROOT_ID = 'ROOT_ID';
+const GRID = 'GRID';
+const TABS = 'TABS';
+const TAB = 'TAB';
+const FILTER_A = 'FILTER_A';
+const FILTER_B = 'FILTER_B';
+const FILTER_C = 'FILTER_C';
+const TAB_A = 'TAB_A';
+const TAB_B = 'TAB_B';
+const CHART_A = 'CHART_A';
+const CHART_B = 'CHART_B';
+const CHART_C = 'CHART_C';
+const CHART_D = 'CHART_D';
+
+const EXPAND_ALL = 'Expand all';
+const COLLAPSE_ALL = 'Collapse all';
+const CHECKED = 'checked';
+const UNCHECKED = 'unchecked';
+const INDETERMINATE = 'indeterminate';
+const ALL_FILTERS = 'All filters';
+const ALL_CHARTS = 'All charts';
+
+const defaultProps = {
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13887:
URL: https://github.com/apache/superset/pull/13887#issuecomment-811266974
# [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=h1) Report
> Merging [#13887](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=desc) (c18b583) into [master](https://codecov.io/gh/apache/superset/commit/e06290663a23740e9cd3f50f2913b016bd7f205f?el=desc) (e062906) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head c18b583 differs from pull request most recent head 52f434a. Consider uploading reports for the commit 52f434a to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13887 +/- ##
==========================================
- Coverage 78.08% 78.07% -0.02%
==========================================
Files 934 935 +1
Lines 47352 47301 -51
Branches 5952 5907 -45
==========================================
- Hits 36976 36928 -48
- Misses 10232 10245 +13
+ Partials 144 128 -16
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `100.00% <ø> (+50.00%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkVHJlZS5qc3g=) | `66.66% <ø> (+22.22%)` | :arrow_up: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `75.00% <ø> (ø)` | |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `87.67% <ø> (+85.61%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterScopeTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlVHJlZS5qc3g=) | `70.00% <ø> (+20.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `90.00% <ø> (+90.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | `86.66% <ø> (+86.66%)` | :arrow_up: |
| [...oard/components/nativeFilters/FilterBar/Header.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci50c3g=) | `87.09% <0.00%> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [88 more](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=footer). Last update [e062906...52f434a](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #13887:
URL: https://github.com/apache/superset/pull/13887#discussion_r606428290
##########
File path: superset-frontend/src/dashboard/components/filterscope/FilterScope.test.tsx
##########
@@ -0,0 +1,372 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import FilterScopeSelector from './FilterScopeSelector';
+
+const ROOT_ID = 'ROOT_ID';
+const GRID = 'GRID';
+const TABS = 'TABS';
+const TAB = 'TAB';
+const FILTER_A = 'FILTER_A';
+const FILTER_B = 'FILTER_B';
+const FILTER_C = 'FILTER_C';
+const TAB_A = 'TAB_A';
+const TAB_B = 'TAB_B';
+const CHART_A = 'CHART_A';
+const CHART_B = 'CHART_B';
+const CHART_C = 'CHART_C';
+const CHART_D = 'CHART_D';
+
+const EXPAND_ALL = 'Expand all';
+const COLLAPSE_ALL = 'Collapse all';
+const CHECKED = 'checked';
+const UNCHECKED = 'unchecked';
+const INDETERMINATE = 'indeterminate';
+const ALL_FILTERS = 'All filters';
+const ALL_CHARTS = 'All charts';
+
+const createProps = () => ({
+ dashboardFilters: {
+ 1: {
+ chartId: 1,
+ componentId: 'component-id',
+ datasourceId: 'datasource-id',
+ directPathToFilter: [],
+ isDateFilter: false,
+ isInstantFilter: false,
+ filterName: FILTER_A,
+ columns: { column_b: undefined, column_c: undefined },
+ labels: { column_b: FILTER_B, column_c: FILTER_C },
+ scopes: {
+ column_b: { immune: [], scope: [ROOT_ID] },
+ column_c: { immune: [], scope: [ROOT_ID] },
+ },
+ },
+ },
+ layout: {
+ ROOT_ID: { children: [GRID], id: ROOT_ID, type: 'ROOT' },
+ GRID: {
+ children: [TABS],
+ id: GRID,
+ type: GRID,
+ parents: [ROOT_ID],
+ },
+ TABS: {
+ children: [TAB_A, TAB_B],
+ id: TABS,
+ type: TABS,
+ parents: [ROOT_ID, GRID],
+ },
+ TAB_A: {
+ meta: { text: TAB_A },
+ children: [CHART_A, CHART_B],
+ id: TAB_A,
+ type: TAB,
+ parents: [ROOT_ID, GRID, TABS],
+ },
+ TAB_B: {
+ meta: { text: TAB_B },
+ children: [CHART_C, CHART_D],
+ id: TAB_B,
+ type: TAB,
+ parents: [ROOT_ID, GRID, TABS],
+ },
+ CHART_A: {
+ meta: {
+ chartId: 2,
+ sliceName: CHART_A,
+ },
+ children: [],
+ id: CHART_A,
+ type: 'CHART',
+ parents: [ROOT_ID, GRID, TABS, TAB_A],
+ },
+ CHART_B: {
+ meta: {
+ chartId: 3,
+ sliceName: CHART_B,
+ },
+ children: [],
+ id: CHART_B,
+ type: 'CHART',
+ parents: [ROOT_ID, GRID, TABS, TAB_A],
+ },
+ CHART_C: {
+ meta: {
+ chartId: 4,
+ sliceName: CHART_C,
+ },
+ children: [],
+ id: CHART_C,
+ type: 'CHART',
+ parents: [ROOT_ID, GRID, TABS, TAB_B],
+ },
+ CHART_D: {
+ meta: {
+ chartId: 5,
+ sliceName: CHART_D,
+ },
+ children: [],
+ id: CHART_D,
+ type: 'CHART',
+ parents: [ROOT_ID, GRID, TABS, TAB_B],
+ },
+ },
+ updateDashboardFiltersScope: jest.fn(),
+ setUnsavedChanges: jest.fn(),
+ onCloseModal: jest.fn(),
+});
+
+type CheckboxState = 'checked' | 'unchecked' | 'indeterminate';
+
+/**
+ * Unfortunatelly react-checkbox-tree doesn't provide an easy way to
+ * access the checkbox icon. We need this function to find the element.
+ */
+function getCheckboxIcon(element: HTMLElement): Element {
+ const parent = element.parentElement!;
+ if (parent.classList.contains('rct-text')) {
+ return parent.children[1];
+ }
+ return getCheckboxIcon(parent);
+}
+
+/**
+ * Unfortunatelly when using react-checkbox-tree, the only perceived change of a
+ * checkbox state change is the fill color of the SVG icon.
+ */
+function getCheckboxState(name: string): CheckboxState {
+ const element = screen.getByRole('link', { name });
+ const svgPath = getCheckboxIcon(element).children[1].children[0].children[0];
+ const fill = svgPath.getAttribute('fill');
+ return fill === '#20A7C9'
+ ? CHECKED
+ : fill === '#999999'
Review comment:
If we use the `SupersetTheme` values here, this test won't break if/when the colors in the theme do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13887:
URL: https://github.com/apache/superset/pull/13887#issuecomment-811266974
# [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=h1) Report
> Merging [#13887](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=desc) (0928cf5) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **increase** coverage by `0.49%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13887 +/- ##
==========================================
+ Coverage 77.55% 78.05% +0.49%
==========================================
Files 935 935
Lines 47301 47326 +25
Branches 5907 5910 +3
==========================================
+ Hits 36685 36938 +253
+ Misses 10472 10260 -212
+ Partials 144 128 -16
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `64.83% <0.00%> (+1.10%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `85.71% <ø> (+35.71%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkVHJlZS5qc3g=) | `64.28% <ø> (+19.84%)` | :arrow_up: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `59.09% <ø> (-15.91%)` | :arrow_down: |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `87.67% <ø> (+85.61%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterScopeTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlVHJlZS5qc3g=) | `68.75% <ø> (+18.75%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `64.28% <ø> (+64.28%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | `86.66% <ø> (+86.66%)` | :arrow_up: |
| [...oard/components/nativeFilters/FilterBar/Header.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci50c3g=) | `84.37% <0.00%> (-2.73%)` | :arrow_down: |
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `100.00% <0.00%> (+14.28%)` | :arrow_up: |
| ... and [14 more](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=footer). Last update [d54cc6d...0928cf5](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13887:
URL: https://github.com/apache/superset/pull/13887#issuecomment-811266974
# [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=h1) Report
> Merging [#13887](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=desc) (ab6bc17) into [master](https://codecov.io/gh/apache/superset/commit/8b9c142e2b3381dc94073bbf935cb2ee87987cba?el=desc) (8b9c142) will **increase** coverage by `0.49%`.
> The diff coverage is `81.25%`.
> :exclamation: Current head ab6bc17 differs from pull request most recent head 61a1181. Consider uploading reports for the commit 61a1181 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13887 +/- ##
==========================================
+ Coverage 77.87% 78.37% +0.49%
==========================================
Files 935 935
Lines 47375 47409 +34
Branches 5964 5967 +3
==========================================
+ Hits 36895 37156 +261
+ Misses 10323 10112 -211
+ Partials 157 141 -16
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `68.22% <90.90%> (+1.10%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `85.71% <ø> (+35.71%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkVHJlZS5qc3g=) | `64.28% <ø> (+19.84%)` | :arrow_up: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `59.09% <ø> (-15.91%)` | :arrow_down: |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `87.67% <ø> (+85.61%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterScopeTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlVHJlZS5qc3g=) | `68.75% <ø> (+18.75%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `64.28% <ø> (+64.28%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | `86.66% <ø> (+86.66%)` | :arrow_up: |
| [...oard/components/nativeFilters/FilterBar/Header.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci50c3g=) | `84.37% <0.00%> (-2.73%)` | :arrow_down: |
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `93.75% <92.85%> (+8.03%)` | :arrow_up: |
| ... and [14 more](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=footer). Last update [8b9c142...61a1181](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13887:
URL: https://github.com/apache/superset/pull/13887#issuecomment-811266974
# [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=h1) Report
> Merging [#13887](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=desc) (c18b583) into [master](https://codecov.io/gh/apache/superset/commit/e06290663a23740e9cd3f50f2913b016bd7f205f?el=desc) (e062906) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head c18b583 differs from pull request most recent head 52f434a. Consider uploading reports for the commit 52f434a to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13887 +/- ##
==========================================
- Coverage 78.08% 78.07% -0.02%
==========================================
Files 934 935 +1
Lines 47352 47301 -51
Branches 5952 5907 -45
==========================================
- Hits 36976 36928 -48
- Misses 10232 10245 +13
+ Partials 144 128 -16
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `100.00% <ø> (+50.00%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkVHJlZS5qc3g=) | `66.66% <ø> (+22.22%)` | :arrow_up: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `75.00% <ø> (ø)` | |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `87.67% <ø> (+85.61%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterScopeTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlVHJlZS5qc3g=) | `70.00% <ø> (+20.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `90.00% <ø> (+90.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | `86.66% <ø> (+86.66%)` | :arrow_up: |
| [...oard/components/nativeFilters/FilterBar/Header.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci50c3g=) | `87.09% <0.00%> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [88 more](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=footer). Last update [e062906...52f434a](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13887:
URL: https://github.com/apache/superset/pull/13887#issuecomment-811266974
# [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=h1) Report
> Merging [#13887](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=desc) (c18b583) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **increase** coverage by `0.51%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head c18b583 differs from pull request most recent head 3827c44. Consider uploading reports for the commit 3827c44 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13887 +/- ##
==========================================
+ Coverage 77.55% 78.07% +0.51%
==========================================
Files 935 935
Lines 47301 47301
Branches 5907 5907
==========================================
+ Hits 36685 36928 +243
+ Misses 10472 10245 -227
+ Partials 144 128 -16
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `100.00% <ø> (+50.00%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkVHJlZS5qc3g=) | `66.66% <ø> (+22.22%)` | :arrow_up: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `75.00% <ø> (ø)` | |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `87.67% <ø> (+85.61%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterScopeTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlVHJlZS5qc3g=) | `70.00% <ø> (+20.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `90.00% <ø> (+90.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | `86.66% <ø> (+86.66%)` | :arrow_up: |
| [...oard/components/nativeFilters/FilterBar/Header.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci50c3g=) | `87.09% <0.00%> (ø)` | |
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `100.00% <0.00%> (+14.28%)` | :arrow_up: |
| ... and [13 more](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=footer). Last update [d54cc6d...3827c44](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13887:
URL: https://github.com/apache/superset/pull/13887#issuecomment-811266974
# [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=h1) Report
> Merging [#13887](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=desc) (c18b583) into [master](https://codecov.io/gh/apache/superset/commit/e06290663a23740e9cd3f50f2913b016bd7f205f?el=desc) (e062906) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head c18b583 differs from pull request most recent head 52f434a. Consider uploading reports for the commit 52f434a to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13887 +/- ##
==========================================
- Coverage 78.08% 78.07% -0.02%
==========================================
Files 934 935 +1
Lines 47352 47301 -51
Branches 5952 5907 -45
==========================================
- Hits 36976 36928 -48
- Misses 10232 10245 +13
+ Partials 144 128 -16
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `100.00% <ø> (+50.00%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkVHJlZS5qc3g=) | `66.66% <ø> (+22.22%)` | :arrow_up: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `75.00% <ø> (ø)` | |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `87.67% <ø> (+85.61%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterScopeTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlVHJlZS5qc3g=) | `70.00% <ø> (+20.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `90.00% <ø> (+90.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | `86.66% <ø> (+86.66%)` | :arrow_up: |
| [...oard/components/nativeFilters/FilterBar/Header.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci50c3g=) | `87.09% <0.00%> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [88 more](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=footer). Last update [e062906...52f434a](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13887:
URL: https://github.com/apache/superset/pull/13887#issuecomment-811266974
# [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=h1) Report
> Merging [#13887](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=desc) (ab6bc17) into [master](https://codecov.io/gh/apache/superset/commit/8b9c142e2b3381dc94073bbf935cb2ee87987cba?el=desc) (8b9c142) will **increase** coverage by `1.20%`.
> The diff coverage is `90.90%`.
> :exclamation: Current head ab6bc17 differs from pull request most recent head 61a1181. Consider uploading reports for the commit 61a1181 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13887 +/- ##
==========================================
+ Coverage 77.87% 79.08% +1.20%
==========================================
Files 935 935
Lines 47375 47379 +4
Branches 5964 5963 -1
==========================================
+ Hits 36895 37468 +573
+ Misses 10323 9784 -539
+ Partials 157 127 -30
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <70.00%> (+5.27%)` | :arrow_up: |
| javascript | `68.22% <90.90%> (+1.10%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `100.00% <ø> (+50.00%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkVHJlZS5qc3g=) | `66.66% <ø> (+22.22%)` | :arrow_up: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `75.00% <ø> (ø)` | |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `87.67% <ø> (+85.61%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterScopeTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlVHJlZS5qc3g=) | `70.00% <ø> (+20.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `90.00% <ø> (+90.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | `86.66% <ø> (+86.66%)` | :arrow_up: |
| [...oard/components/nativeFilters/FilterBar/Header.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci50c3g=) | `87.09% <0.00%> (ø)` | |
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `100.00% <100.00%> (+14.28%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `63.26% <0.00%> (+0.20%)` | :arrow_up: |
| ... and [62 more](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=footer). Last update [8b9c142...61a1181](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13887:
URL: https://github.com/apache/superset/pull/13887#issuecomment-811266974
# [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=h1) Report
> Merging [#13887](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=desc) (c18b583) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `1.32%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head c18b583 differs from pull request most recent head 0928cf5. Consider uploading reports for the commit 0928cf5 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13887 +/- ##
==========================================
- Coverage 77.55% 76.23% -1.33%
==========================================
Files 935 935
Lines 47301 47299 -2
Branches 5907 5907
==========================================
- Hits 36685 36058 -627
- Misses 10472 11075 +603
- Partials 144 166 +22
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `46.79% <0.00%> (-9.24%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `100.00% <ø> (+50.00%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkVHJlZS5qc3g=) | `66.66% <ø> (+22.22%)` | :arrow_up: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `31.25% <ø> (-43.75%)` | :arrow_down: |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `87.67% <ø> (+85.61%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterScopeTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlVHJlZS5qc3g=) | `70.00% <ø> (+20.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `90.00% <ø> (+90.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | `86.66% <ø> (+86.66%)` | :arrow_up: |
| [...oard/components/nativeFilters/FilterBar/Header.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci50c3g=) | `87.09% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [116 more](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=footer). Last update [d54cc6d...0928cf5](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #13887:
URL: https://github.com/apache/superset/pull/13887#discussion_r607028928
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header.tsx
##########
@@ -98,10 +98,14 @@ const Header: FC<HeaderProps> = ({
<span>{t('Filters')}</span>
{canEdit && (
<FilterConfigurationLink createNewOnOpen={filterValues.length === 0}>
- <Icon name="edit" data-test="create-filter" />
+ <Icon name="edit" role="button" data-test="create-filter" />
</FilterConfigurationLink>
)}
- <Icon name="expand" onClick={() => toggleFiltersBar(false)} />
+ <Icon
+ name="expand"
+ role="button"
+ onClick={() => toggleFiltersBar(false)}
Review comment:
I just touched this file to add the button role to the icons. The tests of `FilterBar` are here https://github.com/apache/superset/pull/13916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13887:
URL: https://github.com/apache/superset/pull/13887#issuecomment-811266974
# [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=h1) Report
> Merging [#13887](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=desc) (c18b583) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **increase** coverage by `0.51%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head c18b583 differs from pull request most recent head 0202d9e. Consider uploading reports for the commit 0202d9e to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13887 +/- ##
==========================================
+ Coverage 77.55% 78.07% +0.51%
==========================================
Files 935 935
Lines 47301 47301
Branches 5907 5907
==========================================
+ Hits 36685 36928 +243
+ Misses 10472 10245 -227
+ Partials 144 128 -16
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `100.00% <ø> (+50.00%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkVHJlZS5qc3g=) | `66.66% <ø> (+22.22%)` | :arrow_up: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `75.00% <ø> (ø)` | |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `87.67% <ø> (+85.61%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterScopeTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlVHJlZS5qc3g=) | `70.00% <ø> (+20.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `90.00% <ø> (+90.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | `86.66% <ø> (+86.66%)` | :arrow_up: |
| [...oard/components/nativeFilters/FilterBar/Header.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci50c3g=) | `87.09% <0.00%> (ø)` | |
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `100.00% <0.00%> (+14.28%)` | :arrow_up: |
| ... and [13 more](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=footer). Last update [d54cc6d...0202d9e](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13887:
URL: https://github.com/apache/superset/pull/13887#issuecomment-811266974
# [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=h1) Report
> Merging [#13887](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=desc) (6f1a6ac) into [master](https://codecov.io/gh/apache/superset/commit/e06290663a23740e9cd3f50f2913b016bd7f205f?el=desc) (e062906) will **decrease** coverage by `0.31%`.
> The diff coverage is `85.71%`.
> :exclamation: Current head 6f1a6ac differs from pull request most recent head 52f434a. Consider uploading reports for the commit 52f434a to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13887 +/- ##
==========================================
- Coverage 78.08% 77.76% -0.32%
==========================================
Files 934 951 +17
Lines 47352 48146 +794
Branches 5952 6178 +226
==========================================
+ Hits 36976 37442 +466
- Misses 10232 10577 +345
+ Partials 144 127 -17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <82.75%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `9.52% <0.00%> (ø)` | |
| [...ilterScopingModal/CrossFilterScopingForm/index.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ0Zvcm0vaW5kZXgudHN4) | `12.50% <ø> (ø)` | |
| [...ard/components/FiltersBadge/DetailsPanel/index.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwvaW5kZXgudHN4) | `59.52% <ø> (ø)` | |
| [.../components/FiltersBadge/FilterIndicator/index.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9GaWx0ZXJJbmRpY2F0b3IvaW5kZXgudHN4) | `12.50% <ø> (ø)` | |
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `100.00% <ø> (+50.00%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkVHJlZS5qc3g=) | `66.66% <ø> (+22.22%)` | :arrow_up: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `75.00% <ø> (ø)` | |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `87.67% <ø> (+85.61%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterScopeTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlVHJlZS5qc3g=) | `70.00% <ø> (+20.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `90.00% <ø> (+90.00%)` | :arrow_up: |
| ... and [53 more](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=footer). Last update [e062906...52f434a](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13887:
URL: https://github.com/apache/superset/pull/13887#issuecomment-811266974
# [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=h1) Report
> Merging [#13887](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=desc) (ab6bc17) into [master](https://codecov.io/gh/apache/superset/commit/8b9c142e2b3381dc94073bbf935cb2ee87987cba?el=desc) (8b9c142) will **increase** coverage by `0.59%`.
> The diff coverage is `90.90%`.
> :exclamation: Current head ab6bc17 differs from pull request most recent head 61a1181. Consider uploading reports for the commit 61a1181 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13887 +/- ##
==========================================
+ Coverage 77.87% 78.47% +0.59%
==========================================
Files 935 935
Lines 47375 47378 +3
Branches 5964 5963 -1
==========================================
+ Hits 36895 37181 +286
+ Misses 10323 10062 -261
+ Partials 157 135 -22
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.56% <70.00%> (+5.79%)` | :arrow_up: |
| javascript | `68.22% <90.90%> (+1.10%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `100.00% <ø> (+50.00%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkVHJlZS5qc3g=) | `66.66% <ø> (+22.22%)` | :arrow_up: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `31.25% <ø> (-43.75%)` | :arrow_down: |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `87.67% <ø> (+85.61%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterScopeTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlVHJlZS5qc3g=) | `70.00% <ø> (+20.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `90.00% <ø> (+90.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | `86.66% <ø> (+86.66%)` | :arrow_up: |
| [...oard/components/nativeFilters/FilterBar/Header.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci50c3g=) | `87.09% <0.00%> (ø)` | |
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `100.00% <100.00%> (+14.28%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-59.26%)` | :arrow_down: |
| ... and [70 more](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=footer). Last update [8b9c142...61a1181](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #13887:
URL: https://github.com/apache/superset/pull/13887#discussion_r606429706
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header.tsx
##########
@@ -98,10 +98,14 @@ const Header: FC<HeaderProps> = ({
<span>{t('Filters')}</span>
{canEdit && (
<FilterConfigurationLink createNewOnOpen={filterValues.length === 0}>
- <Icon name="edit" data-test="create-filter" />
+ <Icon name="edit" role="button" data-test="create-filter" />
</FilterConfigurationLink>
)}
- <Icon name="expand" onClick={() => toggleFiltersBar(false)} />
+ <Icon
+ name="expand"
+ role="button"
+ onClick={() => toggleFiltersBar(false)}
Review comment:
Is codecov correct that this is not being tested? If so, should we mock that onClick?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13887:
URL: https://github.com/apache/superset/pull/13887#issuecomment-811266974
# [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=h1) Report
> Merging [#13887](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=desc) (6f1a6ac) into [master](https://codecov.io/gh/apache/superset/commit/e06290663a23740e9cd3f50f2913b016bd7f205f?el=desc) (e062906) will **decrease** coverage by `1.29%`.
> The diff coverage is `85.71%`.
> :exclamation: Current head 6f1a6ac differs from pull request most recent head 52f434a. Consider uploading reports for the commit 52f434a to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13887 +/- ##
==========================================
- Coverage 78.08% 76.79% -1.30%
==========================================
Files 934 951 +17
Lines 47352 48145 +793
Branches 5952 6178 +226
==========================================
- Hits 36976 36973 -3
- Misses 10232 11032 +800
+ Partials 144 140 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.13% <82.75%> (-5.91%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `9.52% <0.00%> (ø)` | |
| [...ilterScopingModal/CrossFilterScopingForm/index.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ0Zvcm0vaW5kZXgudHN4) | `12.50% <ø> (ø)` | |
| [...ard/components/FiltersBadge/DetailsPanel/index.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwvaW5kZXgudHN4) | `57.14% <ø> (ø)` | |
| [.../components/FiltersBadge/FilterIndicator/index.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9GaWx0ZXJJbmRpY2F0b3IvaW5kZXgudHN4) | `12.50% <ø> (ø)` | |
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `100.00% <ø> (+50.00%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkVHJlZS5qc3g=) | `66.66% <ø> (+22.22%)` | :arrow_up: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `75.00% <ø> (ø)` | |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `87.67% <ø> (+85.61%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterScopeTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlVHJlZS5qc3g=) | `70.00% <ø> (+20.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `90.00% <ø> (+90.00%)` | :arrow_up: |
| ... and [114 more](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=footer). Last update [e062906...52f434a](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina closed pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
michael-s-molina closed pull request #13887:
URL: https://github.com/apache/superset/pull/13887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13887:
URL: https://github.com/apache/superset/pull/13887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina closed pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
michael-s-molina closed pull request #13887:
URL: https://github.com/apache/superset/pull/13887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yardz commented on a change in pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
yardz commented on a change in pull request #13887:
URL: https://github.com/apache/superset/pull/13887#discussion_r605839121
##########
File path: superset-frontend/src/dashboard/components/filterscope/FilterScope.test.tsx
##########
@@ -0,0 +1,372 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import FilterScopeSelector from './FilterScopeSelector';
+
+const ROOT_ID = 'ROOT_ID';
+const GRID = 'GRID';
+const TABS = 'TABS';
+const TAB = 'TAB';
+const FILTER_A = 'FILTER_A';
+const FILTER_B = 'FILTER_B';
+const FILTER_C = 'FILTER_C';
+const TAB_A = 'TAB_A';
+const TAB_B = 'TAB_B';
+const CHART_A = 'CHART_A';
+const CHART_B = 'CHART_B';
+const CHART_C = 'CHART_C';
+const CHART_D = 'CHART_D';
+
+const EXPAND_ALL = 'Expand all';
+const COLLAPSE_ALL = 'Collapse all';
+const CHECKED = 'checked';
+const UNCHECKED = 'unchecked';
+const INDETERMINATE = 'indeterminate';
+const ALL_FILTERS = 'All filters';
+const ALL_CHARTS = 'All charts';
+
+const defaultProps = {
Review comment:
Don't you think it would be nice to apply a factory here?
##########
File path: superset-frontend/src/dashboard/components/filterscope/FilterScope.test.tsx
##########
@@ -0,0 +1,372 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import FilterScopeSelector from './FilterScopeSelector';
+
+const ROOT_ID = 'ROOT_ID';
+const GRID = 'GRID';
+const TABS = 'TABS';
+const TAB = 'TAB';
+const FILTER_A = 'FILTER_A';
+const FILTER_B = 'FILTER_B';
+const FILTER_C = 'FILTER_C';
+const TAB_A = 'TAB_A';
+const TAB_B = 'TAB_B';
+const CHART_A = 'CHART_A';
+const CHART_B = 'CHART_B';
+const CHART_C = 'CHART_C';
+const CHART_D = 'CHART_D';
+
+const EXPAND_ALL = 'Expand all';
+const COLLAPSE_ALL = 'Collapse all';
+const CHECKED = 'checked';
+const UNCHECKED = 'unchecked';
+const INDETERMINATE = 'indeterminate';
+const ALL_FILTERS = 'All filters';
+const ALL_CHARTS = 'All charts';
+
+const defaultProps = {
+ dashboardFilters: {
+ 1: {
+ chartId: 1,
+ componentId: 'component-id',
+ datasourceId: 'datasource-id',
+ directPathToFilter: [],
+ isDateFilter: false,
+ isInstantFilter: false,
+ filterName: FILTER_A,
+ columns: { column_b: undefined, column_c: undefined },
+ labels: { column_b: FILTER_B, column_c: FILTER_C },
+ scopes: {
+ column_b: { immune: [], scope: [ROOT_ID] },
+ column_c: { immune: [], scope: [ROOT_ID] },
+ },
+ },
+ },
+ layout: {
+ ROOT_ID: { children: [GRID], id: ROOT_ID, type: 'ROOT' },
+ GRID: {
+ children: [TABS],
+ id: GRID,
+ type: GRID,
+ parents: [ROOT_ID],
+ },
+ TABS: {
+ children: [TAB_A, TAB_B],
+ id: TABS,
+ type: TABS,
+ parents: [ROOT_ID, GRID],
+ },
+ TAB_A: {
+ meta: { text: TAB_A },
+ children: [CHART_A, CHART_B],
+ id: TAB_A,
+ type: TAB,
+ parents: [ROOT_ID, GRID, TABS],
+ },
+ TAB_B: {
+ meta: { text: TAB_B },
+ children: [CHART_C, CHART_D],
+ id: TAB_B,
+ type: TAB,
+ parents: [ROOT_ID, GRID, TABS],
+ },
+ CHART_A: {
+ meta: {
+ chartId: 2,
+ sliceName: CHART_A,
+ },
+ children: [],
+ id: CHART_A,
+ type: 'CHART',
+ parents: [ROOT_ID, GRID, TABS, TAB_A],
+ },
+ CHART_B: {
+ meta: {
+ chartId: 3,
+ sliceName: CHART_B,
+ },
+ children: [],
+ id: CHART_B,
+ type: 'CHART',
+ parents: [ROOT_ID, GRID, TABS, TAB_A],
+ },
+ CHART_C: {
+ meta: {
+ chartId: 4,
+ sliceName: CHART_C,
+ },
+ children: [],
+ id: CHART_C,
+ type: 'CHART',
+ parents: [ROOT_ID, GRID, TABS, TAB_B],
+ },
+ CHART_D: {
+ meta: {
+ chartId: 5,
+ sliceName: CHART_D,
+ },
+ children: [],
+ id: CHART_D,
+ type: 'CHART',
+ parents: [ROOT_ID, GRID, TABS, TAB_B],
+ },
+ },
+ updateDashboardFiltersScope: jest.fn(),
+ setUnsavedChanges: jest.fn(),
+ onCloseModal: jest.fn(),
+};
+
+type CheckboxState = 'checked' | 'unchecked' | 'indeterminate';
+
+/**
+ * Unfortunatelly react-checkbox-tree doesn't provide an easy way to
+ * access the checkbox icon. We need this function to find the element.
+ */
+function getCheckboxIcon(element: HTMLElement): Element {
+ const parent = element.parentElement!;
+ if (parent.classList.contains('rct-text')) {
+ return parent.children[1];
+ }
+ return getCheckboxIcon(parent);
+}
+
+/**
+ * Unfortunatelly when using react-checkbox-tree, the only perceived change of a
+ * checkbox state change is the fill color of the SVG icon.
+ */
+function getCheckboxState(name: string): CheckboxState {
+ const element = screen.getByRole('link', { name });
+ const svgPath = getCheckboxIcon(element).children[1].children[0].children[0];
+ const fill = svgPath.getAttribute('fill');
+ return fill === '#20A7C9'
+ ? CHECKED
+ : fill === '#999999'
+ ? INDETERMINATE
+ : UNCHECKED;
+}
+
+function clickCheckbox(name: string) {
+ const element = screen.getByRole('link', { name });
+ const checkboxLabel = getCheckboxIcon(element);
+ userEvent.click(checkboxLabel);
+}
+
+test('renders with empty filters', () => {
+ render(<FilterScopeSelector {...defaultProps} dashboardFilters={{}} />, {
+ useRedux: true,
+ });
+ expect(screen.getByText('Configure filter scopes')).toBeInTheDocument();
+ expect(
+ screen.getByText('There are no filters in this dashboard.'),
+ ).toBeInTheDocument();
+ expect(screen.getByRole('button', { name: 'Close' })).toBeInTheDocument();
+ expect(
+ screen.queryByRole('button', { name: 'Save' }),
+ ).not.toBeInTheDocument();
+});
+
+test('renders with filters values', () => {
+ render(<FilterScopeSelector {...defaultProps} />, { useRedux: true });
+ expect(screen.getByRole('link', { name: FILTER_A })).toBeInTheDocument();
+ expect(screen.getByRole('link', { name: FILTER_B })).toBeInTheDocument();
+ expect(screen.getByRole('link', { name: FILTER_C })).toBeInTheDocument();
+ expect(screen.getByRole('link', { name: TAB_A })).toBeInTheDocument();
+ expect(screen.getByRole('link', { name: TAB_B })).toBeInTheDocument();
+ expect(screen.queryByText(CHART_A)).not.toBeInTheDocument();
+ expect(screen.queryByText(CHART_B)).not.toBeInTheDocument();
+ expect(screen.queryByText(CHART_C)).not.toBeInTheDocument();
+ expect(screen.queryByText(CHART_D)).not.toBeInTheDocument();
+ expect(screen.getByRole('button', { name: 'Close' })).toBeInTheDocument();
+ expect(screen.getByRole('button', { name: 'Save' })).toBeInTheDocument();
+});
+
+test('collapses/expands all filters', () => {
+ render(<FilterScopeSelector {...defaultProps} />, {
+ useRedux: true,
+ });
+ userEvent.click(screen.getAllByRole('button', { name: COLLAPSE_ALL })[0]);
+ expect(screen.getByRole('link', { name: ALL_FILTERS })).toBeInTheDocument();
+ expect(
+ screen.queryByRole('link', { name: FILTER_A }),
+ ).not.toBeInTheDocument();
+ expect(
+ screen.queryByRole('link', { name: FILTER_B }),
+ ).not.toBeInTheDocument();
+ expect(
+ screen.queryByRole('link', { name: FILTER_C }),
+ ).not.toBeInTheDocument();
+ userEvent.click(screen.getAllByRole('button', { name: EXPAND_ALL })[0]);
+ expect(screen.getByRole('link', { name: ALL_FILTERS })).toBeInTheDocument();
+ expect(screen.getByRole('link', { name: FILTER_A })).toBeInTheDocument();
+ expect(screen.getByRole('link', { name: FILTER_B })).toBeInTheDocument();
+ expect(screen.getByRole('link', { name: FILTER_C })).toBeInTheDocument();
+});
+
+test('collapses/expands all charts', () => {
+ render(<FilterScopeSelector {...defaultProps} />, {
+ useRedux: true,
+ });
+ userEvent.click(screen.getAllByRole('button', { name: COLLAPSE_ALL })[1]);
+ expect(screen.getByText(ALL_CHARTS)).toBeInTheDocument();
+ expect(screen.queryByText(CHART_A)).not.toBeInTheDocument();
+ expect(screen.queryByText(CHART_B)).not.toBeInTheDocument();
+ expect(screen.queryByText(CHART_C)).not.toBeInTheDocument();
+ expect(screen.queryByText(CHART_D)).not.toBeInTheDocument();
+ userEvent.click(screen.getAllByRole('button', { name: EXPAND_ALL })[1]);
+ expect(screen.getByText(ALL_CHARTS)).toBeInTheDocument();
+ expect(screen.getByRole('link', { name: CHART_A })).toBeInTheDocument();
+ expect(screen.getByRole('link', { name: CHART_B })).toBeInTheDocument();
+ expect(screen.getByRole('link', { name: CHART_C })).toBeInTheDocument();
+ expect(screen.getByRole('link', { name: CHART_D })).toBeInTheDocument();
+});
+
+test('searches for a chart', () => {
+ render(<FilterScopeSelector {...defaultProps} />, {
+ useRedux: true,
+ });
+ userEvent.type(screen.getByPlaceholderText('Search...'), CHART_C);
+ expect(screen.queryByRole('link', { name: CHART_A })).not.toBeInTheDocument();
+ expect(screen.queryByRole('link', { name: CHART_B })).not.toBeInTheDocument();
+ expect(screen.getByRole('link', { name: CHART_C })).toBeInTheDocument();
+});
+
+test('selects a leaf filter', () => {
+ render(<FilterScopeSelector {...defaultProps} />, {
+ useRedux: true,
+ });
+ expect(getCheckboxState(FILTER_C)).toBe(UNCHECKED);
+ clickCheckbox(FILTER_C);
+ expect(getCheckboxState(FILTER_C)).toBe(CHECKED);
+});
+
+test('selects a leaf chart', () => {
+ render(<FilterScopeSelector {...defaultProps} />, {
+ useRedux: true,
+ });
+ userEvent.click(screen.getAllByRole('button', { name: EXPAND_ALL })[1]);
+ expect(getCheckboxState(CHART_D)).toBe(UNCHECKED);
+ clickCheckbox(CHART_D);
+ expect(getCheckboxState(CHART_D)).toBe(CHECKED);
+});
+
+test('selects a branch of filters', () => {
+ render(<FilterScopeSelector {...defaultProps} />, {
+ useRedux: true,
+ });
+ expect(getCheckboxState(FILTER_A)).toBe(UNCHECKED);
+ expect(getCheckboxState(FILTER_B)).toBe(UNCHECKED);
+ expect(getCheckboxState(FILTER_C)).toBe(UNCHECKED);
+ clickCheckbox(FILTER_A);
+ expect(getCheckboxState(FILTER_A)).toBe(CHECKED);
+ expect(getCheckboxState(FILTER_B)).toBe(CHECKED);
+ expect(getCheckboxState(FILTER_C)).toBe(CHECKED);
+});
+
+test('selects a branch of charts', () => {
+ render(<FilterScopeSelector {...defaultProps} />, {
+ useRedux: true,
+ });
+
+ const tabA = screen.getByText(TAB_A);
+ userEvent.click(tabA);
+
+ expect(getCheckboxState(TAB_A)).toBe(UNCHECKED);
+ expect(getCheckboxState(CHART_A)).toBe(UNCHECKED);
+ expect(getCheckboxState(CHART_B)).toBe(UNCHECKED);
+ clickCheckbox(TAB_A);
+ expect(getCheckboxState(TAB_A)).toBe(CHECKED);
+ expect(getCheckboxState(CHART_A)).toBe(CHECKED);
+ expect(getCheckboxState(CHART_B)).toBe(CHECKED);
+});
+
+test('selects all filters', () => {
+ render(<FilterScopeSelector {...defaultProps} />, {
+ useRedux: true,
+ });
+ userEvent.click(screen.getAllByRole('button', { name: EXPAND_ALL })[0]);
+ expect(getCheckboxState(ALL_FILTERS)).toBe(UNCHECKED);
+ expect(getCheckboxState(FILTER_A)).toBe(UNCHECKED);
+ expect(getCheckboxState(FILTER_B)).toBe(UNCHECKED);
+ expect(getCheckboxState(FILTER_C)).toBe(UNCHECKED);
+ clickCheckbox(ALL_FILTERS);
+ expect(getCheckboxState(ALL_FILTERS)).toBe(CHECKED);
+ expect(getCheckboxState(FILTER_A)).toBe(CHECKED);
+ expect(getCheckboxState(FILTER_B)).toBe(CHECKED);
+ expect(getCheckboxState(FILTER_C)).toBe(CHECKED);
+});
+
+test('selects all charts', () => {
+ render(<FilterScopeSelector {...defaultProps} />, {
+ useRedux: true,
+ });
+ userEvent.click(screen.getAllByRole('button', { name: EXPAND_ALL })[1]);
+ expect(getCheckboxState(TAB_A)).toBe(UNCHECKED);
+ expect(getCheckboxState(CHART_A)).toBe(UNCHECKED);
+ expect(getCheckboxState(CHART_B)).toBe(UNCHECKED);
+ expect(getCheckboxState(TAB_B)).toBe(UNCHECKED);
+ expect(getCheckboxState(CHART_C)).toBe(UNCHECKED);
+ expect(getCheckboxState(CHART_D)).toBe(UNCHECKED);
+ clickCheckbox(ALL_CHARTS);
+ expect(getCheckboxState(TAB_A)).toBe(CHECKED);
+ expect(getCheckboxState(CHART_A)).toBe(CHECKED);
+ expect(getCheckboxState(CHART_B)).toBe(CHECKED);
+ expect(getCheckboxState(TAB_B)).toBe(CHECKED);
+ expect(getCheckboxState(CHART_C)).toBe(CHECKED);
+ expect(getCheckboxState(CHART_D)).toBe(CHECKED);
+});
+
+test('triggers onClose', () => {
+ const onCloseModal = jest.fn();
+ render(
+ <FilterScopeSelector {...defaultProps} onCloseModal={onCloseModal} />,
+ {
+ useRedux: true,
+ },
+ );
+ expect(onCloseModal).toHaveBeenCalledTimes(0);
+ userEvent.click(screen.getByRole('button', { name: 'Close' }));
+ expect(onCloseModal).toHaveBeenCalledTimes(1);
Review comment:
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13887:
URL: https://github.com/apache/superset/pull/13887#issuecomment-811266974
# [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=h1) Report
> Merging [#13887](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=desc) (6f1a6ac) into [master](https://codecov.io/gh/apache/superset/commit/e06290663a23740e9cd3f50f2913b016bd7f205f?el=desc) (e062906) will **decrease** coverage by `0.31%`.
> The diff coverage is `85.71%`.
> :exclamation: Current head 6f1a6ac differs from pull request most recent head 52f434a. Consider uploading reports for the commit 52f434a to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13887 +/- ##
==========================================
- Coverage 78.08% 77.76% -0.32%
==========================================
Files 934 951 +17
Lines 47352 48146 +794
Branches 5952 6178 +226
==========================================
+ Hits 36976 37442 +466
- Misses 10232 10577 +345
+ Partials 144 127 -17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <82.75%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `9.52% <0.00%> (ø)` | |
| [...ilterScopingModal/CrossFilterScopingForm/index.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ0Zvcm0vaW5kZXgudHN4) | `12.50% <ø> (ø)` | |
| [...ard/components/FiltersBadge/DetailsPanel/index.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwvaW5kZXgudHN4) | `59.52% <ø> (ø)` | |
| [.../components/FiltersBadge/FilterIndicator/index.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9GaWx0ZXJJbmRpY2F0b3IvaW5kZXgudHN4) | `12.50% <ø> (ø)` | |
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `100.00% <ø> (+50.00%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkVHJlZS5qc3g=) | `66.66% <ø> (+22.22%)` | :arrow_up: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `75.00% <ø> (ø)` | |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `87.67% <ø> (+85.61%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterScopeTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlVHJlZS5qc3g=) | `70.00% <ø> (+20.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `90.00% <ø> (+90.00%)` | :arrow_up: |
| ... and [53 more](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=footer). Last update [e062906...52f434a](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #13887:
URL: https://github.com/apache/superset/pull/13887#discussion_r607067996
##########
File path: superset-frontend/src/dashboard/components/filterscope/FilterScope.test.tsx
##########
@@ -0,0 +1,372 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import FilterScopeSelector from './FilterScopeSelector';
+
+const ROOT_ID = 'ROOT_ID';
+const GRID = 'GRID';
+const TABS = 'TABS';
+const TAB = 'TAB';
+const FILTER_A = 'FILTER_A';
+const FILTER_B = 'FILTER_B';
+const FILTER_C = 'FILTER_C';
+const TAB_A = 'TAB_A';
+const TAB_B = 'TAB_B';
+const CHART_A = 'CHART_A';
+const CHART_B = 'CHART_B';
+const CHART_C = 'CHART_C';
+const CHART_D = 'CHART_D';
+
+const EXPAND_ALL = 'Expand all';
+const COLLAPSE_ALL = 'Collapse all';
+const CHECKED = 'checked';
+const UNCHECKED = 'unchecked';
+const INDETERMINATE = 'indeterminate';
+const ALL_FILTERS = 'All filters';
+const ALL_CHARTS = 'All charts';
+
+const createProps = () => ({
+ dashboardFilters: {
+ 1: {
+ chartId: 1,
+ componentId: 'component-id',
+ datasourceId: 'datasource-id',
+ directPathToFilter: [],
+ isDateFilter: false,
+ isInstantFilter: false,
+ filterName: FILTER_A,
+ columns: { column_b: undefined, column_c: undefined },
+ labels: { column_b: FILTER_B, column_c: FILTER_C },
+ scopes: {
+ column_b: { immune: [], scope: [ROOT_ID] },
+ column_c: { immune: [], scope: [ROOT_ID] },
+ },
+ },
+ },
+ layout: {
+ ROOT_ID: { children: [GRID], id: ROOT_ID, type: 'ROOT' },
+ GRID: {
+ children: [TABS],
+ id: GRID,
+ type: GRID,
+ parents: [ROOT_ID],
+ },
+ TABS: {
+ children: [TAB_A, TAB_B],
+ id: TABS,
+ type: TABS,
+ parents: [ROOT_ID, GRID],
+ },
+ TAB_A: {
+ meta: { text: TAB_A },
+ children: [CHART_A, CHART_B],
+ id: TAB_A,
+ type: TAB,
+ parents: [ROOT_ID, GRID, TABS],
+ },
+ TAB_B: {
+ meta: { text: TAB_B },
+ children: [CHART_C, CHART_D],
+ id: TAB_B,
+ type: TAB,
+ parents: [ROOT_ID, GRID, TABS],
+ },
+ CHART_A: {
+ meta: {
+ chartId: 2,
+ sliceName: CHART_A,
+ },
+ children: [],
+ id: CHART_A,
+ type: 'CHART',
+ parents: [ROOT_ID, GRID, TABS, TAB_A],
+ },
+ CHART_B: {
+ meta: {
+ chartId: 3,
+ sliceName: CHART_B,
+ },
+ children: [],
+ id: CHART_B,
+ type: 'CHART',
+ parents: [ROOT_ID, GRID, TABS, TAB_A],
+ },
+ CHART_C: {
+ meta: {
+ chartId: 4,
+ sliceName: CHART_C,
+ },
+ children: [],
+ id: CHART_C,
+ type: 'CHART',
+ parents: [ROOT_ID, GRID, TABS, TAB_B],
+ },
+ CHART_D: {
+ meta: {
+ chartId: 5,
+ sliceName: CHART_D,
+ },
+ children: [],
+ id: CHART_D,
+ type: 'CHART',
+ parents: [ROOT_ID, GRID, TABS, TAB_B],
+ },
+ },
+ updateDashboardFiltersScope: jest.fn(),
+ setUnsavedChanges: jest.fn(),
+ onCloseModal: jest.fn(),
+});
+
+type CheckboxState = 'checked' | 'unchecked' | 'indeterminate';
+
+/**
+ * Unfortunatelly react-checkbox-tree doesn't provide an easy way to
+ * access the checkbox icon. We need this function to find the element.
+ */
+function getCheckboxIcon(element: HTMLElement): Element {
+ const parent = element.parentElement!;
+ if (parent.classList.contains('rct-text')) {
+ return parent.children[1];
+ }
+ return getCheckboxIcon(parent);
+}
+
+/**
+ * Unfortunatelly when using react-checkbox-tree, the only perceived change of a
+ * checkbox state change is the fill color of the SVG icon.
+ */
+function getCheckboxState(name: string): CheckboxState {
+ const element = screen.getByRole('link', { name });
+ const svgPath = getCheckboxIcon(element).children[1].children[0].children[0];
+ const fill = svgPath.getAttribute('fill');
+ return fill === '#20A7C9'
+ ? CHECKED
+ : fill === '#999999'
Review comment:
Great tip! Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #13887:
URL: https://github.com/apache/superset/pull/13887#discussion_r607028928
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header.tsx
##########
@@ -98,10 +98,14 @@ const Header: FC<HeaderProps> = ({
<span>{t('Filters')}</span>
{canEdit && (
<FilterConfigurationLink createNewOnOpen={filterValues.length === 0}>
- <Icon name="edit" data-test="create-filter" />
+ <Icon name="edit" role="button" data-test="create-filter" />
</FilterConfigurationLink>
)}
- <Icon name="expand" onClick={() => toggleFiltersBar(false)} />
+ <Icon
+ name="expand"
+ role="button"
+ onClick={() => toggleFiltersBar(false)}
Review comment:
I just touched this file to add the `button` role to the icons. The tests of `FilterBar` are here https://github.com/apache/superset/pull/13916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13887: test: Adds tests to the filter scope components
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13887:
URL: https://github.com/apache/superset/pull/13887#issuecomment-811266974
# [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=h1) Report
> Merging [#13887](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=desc) (c18b583) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **increase** coverage by `0.51%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head c18b583 differs from pull request most recent head 0928cf5. Consider uploading reports for the commit 0928cf5 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13887 +/- ##
==========================================
+ Coverage 77.55% 78.07% +0.51%
==========================================
Files 935 935
Lines 47301 47301
Branches 5907 5907
==========================================
+ Hits 36685 36928 +243
+ Misses 10472 10245 -227
+ Partials 144 128 -16
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `100.00% <ø> (+50.00%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkVHJlZS5qc3g=) | `66.66% <ø> (+22.22%)` | :arrow_up: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `75.00% <ø> (ø)` | |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `87.67% <ø> (+85.61%)` | :arrow_up: |
| [...shboard/components/filterscope/FilterScopeTree.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlVHJlZS5qc3g=) | `70.00% <ø> (+20.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `90.00% <ø> (+90.00%)` | :arrow_up: |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | `86.66% <ø> (+86.66%)` | :arrow_up: |
| [...oard/components/nativeFilters/FilterBar/Header.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci50c3g=) | `87.09% <0.00%> (ø)` | |
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `100.00% <0.00%> (+14.28%)` | :arrow_up: |
| ... and [13 more](https://codecov.io/gh/apache/superset/pull/13887/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=footer). Last update [d54cc6d...0928cf5](https://codecov.io/gh/apache/superset/pull/13887?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org