You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2009/01/06 11:27:44 UTC

[jira] Created: (JCR-1921) EventFilterImpl should implement toString

EventFilterImpl should implement toString
-----------------------------------------

                 Key: JCR-1921
                 URL: https://issues.apache.org/jira/browse/JCR-1921
             Project: Jackrabbit
          Issue Type: Improvement
          Components: jackrabbit-spi-commons
            Reporter: Michael Dürig


This would simplify logging and debugging.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1921) EventFilterImpl should implement toString

Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig updated JCR-1921:
-------------------------------

    Attachment: JCR-1921.patch

Proposed patch

> EventFilterImpl should implement toString
> -----------------------------------------
>
>                 Key: JCR-1921
>                 URL: https://issues.apache.org/jira/browse/JCR-1921
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-spi-commons
>            Reporter: Michael Dürig
>         Attachments: JCR-1921.patch
>
>
> This would simplify logging and debugging.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1921) EventFilterImpl should implement toString

Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661141#action_12661141 ] 

Marcel Reutegger commented on JCR-1921:
---------------------------------------

I'd rather not keep the string representation in asString. The method toString() is only used for debugging, right? Which means there is no need to make it quick for frequent calls.

> EventFilterImpl should implement toString
> -----------------------------------------
>
>                 Key: JCR-1921
>                 URL: https://issues.apache.org/jira/browse/JCR-1921
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-spi-commons
>            Reporter: Michael Dürig
>         Attachments: JCR-1921.patch
>
>
> This would simplify logging and debugging.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (JCR-1921) EventFilterImpl should implement toString

Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig closed JCR-1921.
------------------------------

    Assignee: Marcel Reutegger

> EventFilterImpl should implement toString
> -----------------------------------------
>
>                 Key: JCR-1921
>                 URL: https://issues.apache.org/jira/browse/JCR-1921
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-spi-commons
>            Reporter: Michael Dürig
>            Assignee: Marcel Reutegger
>             Fix For: 1.6.0
>
>         Attachments: JCR-1921.patch
>
>
> This would simplify logging and debugging.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1921) EventFilterImpl should implement toString

Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661151#action_12661151 ] 

Michael Dürig commented on JCR-1921:
------------------------------------

That's fine with me. Do you need me to update the patch?

> EventFilterImpl should implement toString
> -----------------------------------------
>
>                 Key: JCR-1921
>                 URL: https://issues.apache.org/jira/browse/JCR-1921
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-spi-commons
>            Reporter: Michael Dürig
>         Attachments: JCR-1921.patch
>
>
> This would simplify logging and debugging.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JCR-1921) EventFilterImpl should implement toString

Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcel Reutegger resolved JCR-1921.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.6.0

Committed a changed version of the patch where the string is not held as local variable. svn revision: 732678


> EventFilterImpl should implement toString
> -----------------------------------------
>
>                 Key: JCR-1921
>                 URL: https://issues.apache.org/jira/browse/JCR-1921
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-spi-commons
>            Reporter: Michael Dürig
>             Fix For: 1.6.0
>
>         Attachments: JCR-1921.patch
>
>
> This would simplify logging and debugging.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.