You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/10/28 19:48:27 UTC

[GitHub] [cassandra] belliottsmith commented on a change in pull request #1291: Refactor normal/preview/IR repair to standardize repair cleanup and error handling of failed RepairJobs

belliottsmith commented on a change in pull request #1291:
URL: https://github.com/apache/cassandra/pull/1291#discussion_r738707639



##########
File path: src/java/org/apache/cassandra/utils/concurrent/ListenerList.java
##########
@@ -159,8 +165,18 @@ static ListenerList pushHead(ListenerList prev, ListenerList next)
      */
     static void notifyListener(@Nullable Executor notifyExecutor, Runnable listener)
     {
-        if (notifyExecutor == null) ImmediateExecutor.INSTANCE.execute(listener);
-        else notifyExecutor.execute(listener);
+        if (notifyExecutor == null)
+            notifyExecutor = ImmediateExecutor.INSTANCE;
+
+        try
+        {
+            notifyExecutor.execute(listener);

Review comment:
       > when ImmediateExecutor is used if the listener throws this call site also throws.
   
   This appears to be an issue with Guava's `directExecutor`, rather than `ImmediateExecutor`. We should consider removing `directExecutor` and forbidding it with checkstyle




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org