[GitHub] [incubator-opendal] wcy-fdu commented on a diff in pull request #2143: feat(writer): configurable buffer size of unsized write

["wcy-fdu (via GitHub)" <gi...@apache.org>]

wcy-fdu commented on code in PR #2143:
URL: https://github.com/apache/incubator-opendal/pull/2143#discussion_r1178877990


##########
core/src/services/s3/backend.rs:
##########
@@ -986,10 +996,13 @@ impl Accessor for S3Backend {
     }
 
     async fn write(&self, path: &str, args: OpWrite) -> Result<(RpWrite, Self::Writer)> {
-        Ok((
-            RpWrite::default(),
-            S3Writer::new(self.core.clone(), path, args),
-        ))
+        let s3_writer = match self.core.write_buffer_size {
+            Some(buffer_size) => {
+                S3Writer::new_with_buffer_size(self.core.clone(), path, args, buffer_size)

Review Comment:
   LGTM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org