[GitHub] [helix] subprotocol edited a comment on issue #1888: Ephemeral Instance Support

[GitBox <gi...@apache.org>]

subprotocol edited a comment on issue #1888:
URL: https://github.com/apache/helix/issues/1888#issuecomment-940121753


   @jiajunwang thank you for the suggestion. I added a periodic check to the leading controller and this works great!
   
   I see one possible improvement to purgeOfflineInstances.  I am using helix instance tags to tag my spot instances.  It would be nice if purgeOfflineInstances could take a set of tags, and only purge those tagged instances.  This would allow me to purge the spot instances only, while also mitigating the race condition for other instances.
   
   I would like to propose adding a second purgeOfflineInstances method as follows:
   
   ```java
   // proposed addition
   void purgeOfflineInstances(String clusterName, long offlineDuration, Set<String> instanceTags);
   ```
   
   Does this make sense—and would this functionality be welcome as a small contribution?
   
   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org