[GitHub] [superset] villebro edited a comment on pull request #18252: fix(plugin-chart-echarts): fix forecasts on verbose metrics

[GitBox <gi...@apache.org>]

villebro edited a comment on pull request #18252:
URL: https://github.com/apache/superset/pull/18252#issuecomment-1027827385


   > The fix doesn't seem to be working well with `GENERIC_CHART_AXES` ff disabled - Y axis is scaled to timestamp epoch values
   
   Great catch! It turns out `datasource.verboseMap` always includes an entry `{ __timestamp: 'Time' }` which threw the util function off when it was made more generic. I added added a check for it + added a test for making sure the alias stays unchanged (this logic will be removed once we remove the legacy non-generic timeseries functionality).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org