You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/03 11:00:38 UTC

[GitHub] [pulsar-client-node] dionjansen edited a comment on pull request #101: Get redelivery count

dionjansen edited a comment on pull request #101:
URL: https://github.com/apache/pulsar-client-node/pull/101#issuecomment-653489056


   @massakam sorry for the mess I hadn't actually ran the code locally, linter works fine for me now. One unit test is failing though:
   
   ```
    FAIL  tests/consumer.test.js
     Consumer
       Create
         ✓ No Topic (11ms)
         ✓ Not String Topic (1ms)
         ✓ No Subscription (1ms)
         ✓ Not String Subscription
         ✓ Not Exist Tenant (3ms)
         ✓ Not Exist Namespace (1ms)
         ✓ Not Positive NAckRedeliverTimeout
       Close
         ✕ throws error on subsequent calls to close (2ms)
   
     ● Consumer › Close › throws error on subsequent calls to close
   
       Failed to create consumer: ConnectError
   ```
   
   *fyi I don't have a pulsar cluster running on localhost atm, so all the e2e tests fail but that expected.*


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org