You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by devsprint <gi...@git.apache.org> on 2014/06/26 17:47:35 UTC
[GitHub] incubator-storm pull request: migrated to curator 2.5.0
GitHub user devsprint opened a pull request:
https://github.com/apache/incubator-storm/pull/165
migrated to curator 2.5.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/devsprint/incubator-storm curator-2.5.0
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/165.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #165
----
commit 99b914ce0a9cc8185dbcf721eb428568c121cfb3
Author: Gabriel Ciuloaica <gc...@gmail.com>
Date: 2014-06-26T15:45:29Z
migrated to curator 2.5.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-453 - migrated to curator 2.5....
Posted by devsprint <gi...@git.apache.org>.
Github user devsprint commented on the pull request:
https://github.com/apache/incubator-storm/pull/165#issuecomment-52551956
@revans2 please go ahead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-453 - migrated to curator 2.5....
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/165#issuecomment-52548704
I tried the change both with and without the updates suggested by @viktortnk Both passed and I am fine either way. @devsprint if you want me to I will merge it in as is and file another JIRA for the other updates. If you want to update the dependencies then I'll merge that in when you are done too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-453 - migrated to curator 2.5....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-storm/pull/165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-453 - migrated to curator 2.5....
Posted by viktortnk <gi...@git.apache.org>.
Github user viktortnk commented on the pull request:
https://github.com/apache/incubator-storm/pull/165#issuecomment-52432065
does it make sense to update this PR with newer versions of curator, guava and netty before merge.
Btw, current version of cassandra driver mentioned has guava 16.0.1 and netty 3.9.0 in it's list
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: migrated to curator 2.5.0
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/165#issuecomment-49434895
The changes seem OK to me, but I would like to see a JIRA filed for this and the JIRA number (i.e. STORM-12345) added to the title of the pull request. I really should have gotten to this a long tim ago, sorry it has taken so long.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-453 - migrated to curator 2.5....
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/165#issuecomment-52552793
+1 I'll merge both sets of changes into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: migrated to curator 2.5.0
Posted by devsprint <gi...@git.apache.org>.
Github user devsprint commented on the pull request:
https://github.com/apache/incubator-storm/pull/165#issuecomment-52046442
Sorry, I haven't seen this update. JIRA ticket is below.
https://issues.apache.org/jira/browse/STORM-453
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---