You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "LuGuangming (via GitHub)" <gi...@apache.org> on 2026/03/27 12:54:39 UTC
[PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
LuGuangming opened a new pull request, #61829:
URL: https://github.com/apache/doris/pull/61829
…data fails
### What problem does this PR solve?
Issue Number: close #61827
Related PR: #xxx
Problem Summary:
After a full synchronization of tables with materialized views, the schema mapping between the materialized views and base tables is not restored after the backup and restoration. As a result, the manual insert into operation fails. After the restoration is successful, the schema mapping between the materialized views and base tables is not established.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4155306057
<details>
<summary>TPC-H: <b>Total hot run time: 26550 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c6567036f954c4006f045e34341c82a99aaf6a5a, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17604 4445 4346 4346
q2 q3 10644 799 539 539
q4 4687 359 249 249
q5 7571 1221 1032 1032
q6 179 174 148 148
q7 789 856 682 682
q8 9333 1461 1342 1342
q9 4780 4756 4719 4719
q10 6241 1917 1653 1653
q11 467 261 255 255
q12 711 584 474 474
q13 18023 2706 1941 1941
q14 230 238 218 218
q15 q16 725 751 663 663
q17 740 861 422 422
q18 5845 5488 5155 5155
q19 1237 978 602 602
q20 541 509 377 377
q21 4765 1822 1400 1400
q22 345 333 442 333
Total cold run time: 95457 ms
Total hot run time: 26550 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4804 4654 4664 4654
q2 q3 3881 4394 3899 3899
q4 905 1190 783 783
q5 4042 4444 4338 4338
q6 193 173 142 142
q7 1769 1703 1526 1526
q8 2480 2699 2502 2502
q9 7619 7328 7524 7328
q10 3803 3964 3586 3586
q11 505 436 412 412
q12 475 590 454 454
q13 2680 2965 2103 2103
q14 284 301 278 278
q15 q16 720 767 722 722
q17 1139 1331 1361 1331
q18 7167 6869 6729 6729
q19 885 888 934 888
q20 2055 2179 2065 2065
q21 3965 3451 3320 3320
q22 487 442 387 387
Total cold run time: 49858 ms
Total hot run time: 47447 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "LuGuangming (via GitHub)" <gi...@apache.org>.
LuGuangming commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4142414547
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4197311709
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4249760740
# FE Regression Coverage Report
Increment line coverage ` 100.00% (1/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61829_97394775b55c4a32cdd3fd1e992ead65d2ae954c_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61829_97394775b55c4a32cdd3fd1e992ead65d2ae954c_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4142567411
<details>
<summary>TPC-H: <b>Total hot run time: 26590 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1ee3e2653907524dca659a4eb5acde750565bc6a, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17611 4570 4275 4275
q2 q3 10657 783 539 539
q4 4673 355 248 248
q5 7565 1211 998 998
q6 176 174 146 146
q7 767 878 676 676
q8 9318 1511 1388 1388
q9 4970 4727 4646 4646
q10 6344 1907 1664 1664
q11 446 252 253 252
q12 770 584 476 476
q13 18032 2682 1959 1959
q14 231 234 218 218
q15 q16 746 720 659 659
q17 721 877 445 445
q18 5892 5487 5271 5271
q19 1117 1001 626 626
q20 532 495 369 369
q21 4555 1823 1417 1417
q22 348 517 318 318
Total cold run time: 95471 ms
Total hot run time: 26590 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4654 4669 4541 4541
q2 q3 3916 4344 3822 3822
q4 891 1199 801 801
q5 4082 4418 4400 4400
q6 198 189 147 147
q7 1809 1736 1537 1537
q8 2564 2785 2587 2587
q9 7516 7690 7491 7491
q10 3889 4089 3647 3647
q11 520 442 436 436
q12 482 606 467 467
q13 2582 2909 2180 2180
q14 300 310 275 275
q15 q16 714 818 731 731
q17 1244 1415 1414 1414
q18 7223 6702 6570 6570
q19 930 922 910 910
q20 2065 2201 2017 2017
q21 4008 3586 3366 3366
q22 478 430 384 384
Total cold run time: 50065 ms
Total hot run time: 47723 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-6135217662
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4248930794
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4197312136
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "w41ter (via GitHub)" <gi...@apache.org>.
w41ter commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4152634839
Please add a regression test to cover this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4155393555
<details>
<summary>TPC-DS: <b>Total hot run time: 168477 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c6567036f954c4006f045e34341c82a99aaf6a5a, data reload: false
query5 4334 643 509 509
query6 339 226 216 216
query7 4208 467 279 279
query8 349 239 223 223
query9 8704 2713 2696 2696
query10 498 394 337 337
query11 7006 5105 4882 4882
query12 180 128 124 124
query13 1284 482 347 347
query14 5712 3773 3398 3398
query14_1 2887 2835 2800 2800
query15 204 198 179 179
query16 1010 528 478 478
query17 1126 750 633 633
query18 2530 461 355 355
query19 221 207 185 185
query20 136 127 126 126
query21 218 139 111 111
query22 13320 13903 14734 13903
query23 16658 16510 16152 16152
query23_1 15937 15674 15706 15674
query24 7177 1636 1229 1229
query24_1 1221 1227 1245 1227
query25 542 457 421 421
query26 1233 263 150 150
query27 2779 485 293 293
query28 4462 1832 1836 1832
query29 864 553 466 466
query30 299 227 191 191
query31 1013 955 870 870
query32 87 72 71 71
query33 510 346 285 285
query34 883 868 520 520
query35 643 688 604 604
query36 1095 1142 1011 1011
query37 134 94 83 83
query38 2950 2890 2822 2822
query39 844 845 809 809
query39_1 800 787 800 787
query40 231 147 133 133
query41 62 62 59 59
query42 259 257 256 256
query43 255 248 220 220
query44
query45 192 186 184 184
query46 877 983 610 610
query47 2126 2164 2079 2079
query48 325 309 237 237
query49 631 475 380 380
query50 692 282 210 210
query51 4040 4023 4021 4021
query52 264 269 255 255
query53 291 335 281 281
query54 326 268 268 268
query55 99 87 80 80
query56 315 320 325 320
query57 1931 1843 1604 1604
query58 284 272 268 268
query59 2787 2970 2739 2739
query60 334 339 320 320
query61 158 159 154 154
query62 638 586 555 555
query63 307 277 270 270
query64 5153 1296 1006 1006
query65
query66 1454 473 353 353
query67 24251 24201 24155 24155
query68
query69 402 304 286 286
query70 996 980 954 954
query71 333 311 295 295
query72 2895 2730 2414 2414
query73 543 536 316 316
query74 9616 9592 9426 9426
query75 2842 2775 2443 2443
query76 2285 1031 686 686
query77 359 388 313 313
query78 10943 11140 10437 10437
query79 1121 758 574 574
query80 1348 633 523 523
query81 538 270 232 232
query82 1318 157 127 127
query83 341 263 242 242
query84 242 123 97 97
query85 926 486 460 460
query86 425 317 286 286
query87 3134 3156 3038 3038
query88 3518 2665 2648 2648
query89 412 383 344 344
query90 2038 176 178 176
query91 169 161 149 149
query92 77 74 74 74
query93 925 862 494 494
query94 637 314 257 257
query95 602 343 321 321
query96 652 514 227 227
query97 2457 2459 2407 2407
query98 237 218 225 218
query99 1024 994 917 917
Total cold run time: 250521 ms
Total hot run time: 168477 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "LuGuangming (via GitHub)" <gi...@apache.org>.
LuGuangming commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4155164976
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4248930505
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4197522703
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "LuGuangming (via GitHub)" <gi...@apache.org>.
LuGuangming commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4155135250
> Please add a regression test to cover this.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #61829:
URL: https://github.com/apache/doris/pull/61829#discussion_r3083822664
##########
regression-test/suites/backup_restore/test_backup_restore_table_mv_inert.groovy:
##########
@@ -0,0 +1,108 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_backup_restore_table_mv_inert", "backup_restore") {
+ String suiteName = "test_backup_restore_table_mv_inert"
+ String repoName = "repo_" + UUID.randomUUID().toString().replace("-", "")
+ String dbName = "${suiteName}_db"
+ String dbName1 = "${suiteName}_db_1"
+ String tableName = "${suiteName}_table"
+ String mvName = "${suiteName}_mv"
+ String snapshotName = "${suiteName}_snapshot"
+
+ def syncer = getSyncer()
+ syncer.createS3Repository(repoName)
+
+ sql "CREATE DATABASE IF NOT EXISTS ${dbName}"
+ sql "DROP TABLE IF EXISTS ${dbName}.${tableName}"
+ sql """
+ CREATE TABLE ${dbName}.${tableName} (
+ `id` LARGEINT NOT NULL,
+ `item` LARGEINT NOT NULL)
+ DUPLICATE KEY(`id`)
+ DISTRIBUTED BY HASH(`id`) BUCKETS 2
+ PROPERTIES
+ (
+ "replication_num" = "1"
+ )
+ """
+
+ List<String> values = []
+ for (int i = 1; i <= 10; ++i) {
+ values.add("(${i}, ${i})")
+ }
+ sql "INSERT INTO ${dbName}.${tableName} VALUES ${values.join(",")}"
+ def result = sql "SELECT * FROM ${dbName}.${tableName}"
+ assertEquals(result.size(), values.size());
+
+ sql """DROP MATERIALIZED VIEW IF EXISTS ${dbName}.${mvName};"""
+ sql """
+ CREATE MATERIALIZED VIEW ${mvName}
+ AS
+ SELECT id as col_a, sum(item) FROM ${dbName}.${tableName} GROUP BY id;
+ """
+
+ def alter_finished = false
+ for (i = 0; i < 60 && !alter_finished; i++) {
+ result = sql_return_maparray "SHOW ALTER TABLE MATERIALIZED VIEW FROM ${dbName}"
+ logger.info("result: ${result}")
+ for (int i = 0; i < result.size(); i++) {
+ if (result[i]['TableName'] == "${tableName}" &&
+ result[i]['RollupIndexName'] == "${mvName}" &&
+ result[i]['State'] == 'FINISHED') {
+ alter_finished = true
+ break
+ }
+ }
+ Thread.sleep(3000)
+ }
+ assertTrue(alter_finished);
+
+ sql """
+ BACKUP SNAPSHOT ${dbName}.${snapshotName}
+ TO `${repoName}`
+ """
+
+ syncer.waitSnapshotFinish(dbName)
+
+ def snapshot = syncer.getSnapshotTimestamp(repoName, snapshotName)
+ assertTrue(snapshot != null)
+
+ sql "DROP DATABASE IF EXISTS ${dbName1}"
+ sql "CREATE DATABASE IF NOT EXISTS ${dbName1}"
+
+ sql """
+ RESTORE SNAPSHOT ${dbName1}.${snapshotName}
+ FROM `${repoName}`
+ PROPERTIES
+ (
+ "backup_timestamp" = "${snapshot}",
+ "reserve_replica" = "true"
+ )
+ """
+
+ syncer.waitAllRestoreFinish(dbName1)
+
+ result = sql "SELECT * FROM ${dbName1}.${tableName}"
Review Comment:
The bug report and PR summary say the failure is a post-restore `manual insert into`, but this regression only does a `SELECT` on the restored table. That is not enough to prove the fix. FE insert planning rebuilds MV columns from `Column.getDefineExpr()` in paths like `BindSink`, so reads can pass while insert still fails. Please add a post-restore `INSERT INTO ${dbName1}.${tableName} VALUES (...)` plus an assertion on the final query result / row count to cover the actual failure mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4142642536
<details>
<summary>TPC-DS: <b>Total hot run time: 168446 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1ee3e2653907524dca659a4eb5acde750565bc6a, data reload: false
query5 4334 632 497 497
query6 332 231 213 213
query7 4219 471 271 271
query8 345 247 225 225
query9 8700 2706 2683 2683
query10 515 386 326 326
query11 7007 5095 4846 4846
query12 180 128 127 127
query13 1269 449 340 340
query14 5755 3712 3555 3555
query14_1 2849 2851 2839 2839
query15 211 195 180 180
query16 972 469 447 447
query17 944 714 594 594
query18 2434 437 339 339
query19 207 204 182 182
query20 134 123 120 120
query21 208 130 107 107
query22 13400 13385 13144 13144
query23 16227 15673 16069 15673
query23_1 16280 16125 16200 16125
query24 7694 1695 1271 1271
query24_1 1276 1295 1348 1295
query25 577 479 448 448
query26 2699 284 165 165
query27 2802 476 291 291
query28 4534 1823 1827 1823
query29 854 557 478 478
query30 298 226 187 187
query31 1014 925 873 873
query32 79 72 73 72
query33 511 337 289 289
query34 902 875 525 525
query35 648 683 593 593
query36 1078 1098 988 988
query37 136 92 80 80
query38 2978 2920 2894 2894
query39 856 838 824 824
query39_1 778 790 785 785
query40 236 153 138 138
query41 63 60 58 58
query42 271 266 261 261
query43 239 255 222 222
query44
query45 238 186 185 185
query46 874 983 608 608
query47 2114 2137 2059 2059
query48 319 327 233 233
query49 633 464 377 377
query50 690 278 216 216
query51 4179 4063 3986 3986
query52 261 272 257 257
query53 297 335 279 279
query54 304 282 257 257
query55 93 92 83 83
query56 323 321 320 320
query57 1959 1831 1595 1595
query58 291 276 275 275
query59 2812 2954 2731 2731
query60 338 364 319 319
query61 158 156 160 156
query62 635 591 560 560
query63 318 283 273 273
query64 5164 1314 1015 1015
query65
query66 1472 454 357 357
query67 24311 24319 24231 24231
query68
query69 415 323 294 294
query70 991 920 919 919
query71 336 309 309 309
query72 3092 2881 2663 2663
query73 553 545 322 322
query74 9650 9573 9398 9398
query75 2882 2779 2507 2507
query76 2304 1040 664 664
query77 372 396 304 304
query78 11039 11087 10463 10463
query79 2575 771 593 593
query80 1741 624 548 548
query81 557 263 230 230
query82 1018 146 120 120
query83 337 271 241 241
query84 296 122 103 103
query85 917 499 455 455
query86 432 314 289 289
query87 3118 3146 3034 3034
query88 3543 2652 2667 2652
query89 420 364 336 336
query90 2005 179 175 175
query91 171 164 143 143
query92 80 71 76 71
query93 1133 838 503 503
query94 639 309 302 302
query95 591 341 374 341
query96 653 511 231 231
query97 2438 2494 2375 2375
query98 237 224 218 218
query99 1011 984 932 932
Total cold run time: 254043 ms
Total hot run time: 168446 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4212755891
# FE UT Coverage Report
Increment line coverage ` 0.00% (0/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61829_928c9a7bb8353c5cd52b71cfe7d3bea9c6161bae/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61829_928c9a7bb8353c5cd52b71cfe7d3bea9c6161bae/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4248932985
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4142395763
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61829:
URL: https://github.com/apache/doris/pull/61829#issuecomment-4142874136
# FE UT Coverage Report
Increment line coverage ` 0.00% (0/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61829_1ee3e2653907524dca659a4eb5acde750565bc6a/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61829_1ee3e2653907524dca659a4eb5acde750565bc6a/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](restore) Fix after the table with MVs backup and restore, load this table failed [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #61829: [fix](restore) Fix after the table with MVs backup and restore, load this table failed
URL: https://github.com/apache/doris/pull/61829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org