You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/11/02 15:33:18 UTC

[GitHub] brooklyn-server pull request #398: BROOKLYN-377: adds testConfigOnParentUses...

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/398

    BROOKLYN-377: adds testConfigOnParentUsesConfigKeyDeclaredOnParent [DO NOT MERGE]

    This PR contains a failing test, which demonstrates the underlying problem in https://issues.apache.org/jira/browse/BROOKLYN-377.
    
    I believe that https://github.com/apache/brooklyn-server/pull/385 will fix this. We should rebase + retest at that point. In particular, if I change `ValueResolver` to delete `.tagIfNotNull(BrooklynTaskTags.getTargetOrContextEntityTag(Tasks.current()))` then the test passes.
    
    @neykov @drigodwin you'll both likely be interested in this.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server BROOKLYN-377

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/398.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #398
    
----
commit 1a1cf356d182c2ae563c0c0c4e755cb345bc0fa2
Author: Aled Sage <al...@gmail.com>
Date:   2016-11-02T15:28:58Z

    BROOKLYN-377: adds testConfigOnParentUsesConfigKeyDeclaredOnParent

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #398: BROOKLYN-377: adds testConfigOnParentUsesConfigK...

Posted by neykov <gi...@git.apache.org>.

Github user neykov commented on the issue:

    https://github.com/apache/brooklyn-server/pull/398
  
    Looks good and build is successful, merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #398: BROOKLYN-377: adds testConfigOnParentUses...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/398


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #398: BROOKLYN-377: adds testConfigOnParentUsesConfigK...

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/398
  
    #385 is now merged; I've rebased against master. The "many times" now passes for me. Assuming jenkins passes, this will be good to merge I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---