[GitHub] [incubator-superset] michellethomas opened a new pull request #7586: Remove aggregates from metric options if datasource has no columns

[GitBox <gi...@apache.org>]

michellethomas opened a new pull request #7586: Remove aggregates from metric options if datasource has no columns
URL: https://github.com/apache/incubator-superset/pull/7586
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   In the rare case that a datasource doesn't have columns, we should avoid showing aggregates in the metrics control dropdown because they wouldn't be relevant without columns to use them with.
   
   ### TEST PLAN
   Create a datasource with no columns (only metrics)
   Check the metrics dropdown to make sure SUM, MIN, MAX aggregates don't show up
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @graceguo-supercat @kristw 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org