You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/04/07 10:25:09 UTC
[GitHub] [cassandra-builds] michaelsembwever opened a new pull request #41: Use the jenkins agent API to identify when the agent is idle
michaelsembwever opened a new pull request #41:
URL: https://github.com/apache/cassandra-builds/pull/41
(for when it is safe to remove docker volumes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on pull request #41: Use the jenkins agent API to identify when the agent is idle
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on pull request #41:
URL: https://github.com/apache/cassandra-builds/pull/41#issuecomment-814803243
Tested on https://ci-cassandra.apache.org/job/Cassandra-devbranch-test/379/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever edited a comment on pull request #41: Use the jenkins agent API to identify when the agent is idle
Posted by GitBox <gi...@apache.org>.
michaelsembwever edited a comment on pull request #41:
URL: https://github.com/apache/cassandra-builds/pull/41#issuecomment-819262803
I'm reverting this commit. Because the call to the agent API is called from a job on that agent, so the result is never idle :'(
Lots of agents filled up their disk this week, from docker volumes not getting pruned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever closed pull request #41: Use the jenkins agent API to identify when the agent is idle
Posted by GitBox <gi...@apache.org>.
michaelsembwever closed pull request #41:
URL: https://github.com/apache/cassandra-builds/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on pull request #41: Use the jenkins agent API to identify when the agent is idle
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on pull request #41:
URL: https://github.com/apache/cassandra-builds/pull/41#issuecomment-815127119
merged manually with https://github.com/apache/cassandra-builds/commit/6bffb4b5e550d1a59d79a61c7df38f9d9f338fbe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on a change in pull request #41: Use the jenkins agent API to identify when the agent is idle
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #41:
URL: https://github.com/apache/cassandra-builds/pull/41#discussion_r608539697
##########
File path: jenkins-dsl/cassandra_job_dsl_seed.groovy
##########
@@ -573,10 +573,11 @@ cassandraBranches.each {
}
}
postBuildTask {
- // the pgrep needs to catch any other build/process that is using docker
+ // docker needs to (soon or later) prune its volumes too, but that can only be done when the agent is idle
Review comment:
volumes can't be removed with the until filter is used.
so if the agents is otherwise busy, we only removed stuff that's more than 18 hours old (no build is running that long).
when the agent is idle, we know we can wipe it all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on a change in pull request #41: Use the jenkins agent API to identify when the agent is idle
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #41:
URL: https://github.com/apache/cassandra-builds/pull/41#discussion_r608542306
##########
File path: jenkins-dsl/cassandra_job_dsl_seed.groovy
##########
@@ -573,10 +573,11 @@ cassandraBranches.each {
}
}
postBuildTask {
- // the pgrep needs to catch any other build/process that is using docker
+ // docker needs to (soon or later) prune its volumes too, but that can only be done when the agent is idle
Review comment:
comment added/extended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on pull request #41: Use the jenkins agent API to identify when the agent is idle
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on pull request #41:
URL: https://github.com/apache/cassandra-builds/pull/41#issuecomment-819262803
I'm reverting this commit. Because the call to the agent API is call from a job to that agent, it is never idle :'(
Lots of agents filled up their disk this week, from docker volumes not getting pruned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] tlasica commented on pull request #41: Use the jenkins agent API to identify when the agent is idle
Posted by GitBox <gi...@apache.org>.
tlasica commented on pull request #41:
URL: https://github.com/apache/cassandra-builds/pull/41#issuecomment-819299492
Ok. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] tlasica commented on a change in pull request #41: Use the jenkins agent API to identify when the agent is idle
Posted by GitBox <gi...@apache.org>.
tlasica commented on a change in pull request #41:
URL: https://github.com/apache/cassandra-builds/pull/41#discussion_r608537269
##########
File path: jenkins-dsl/cassandra_job_dsl_seed.groovy
##########
@@ -573,10 +573,11 @@ cassandraBranches.each {
}
}
postBuildTask {
- // the pgrep needs to catch any other build/process that is using docker
+ // docker needs to (soon or later) prune its volumes too, but that can only be done when the agent is idle
Review comment:
so when the agent is idle we remove docker volumes...
... but when it is not idle then ?
what actually we do with `docker system prune --all --force --filter `until=...` ?
Maybe worth explaining the rationale in the comment in L576?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org