You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/21 07:30:59 UTC

[GitHub] [camel] essobedo commented on a diff in pull request #8602: camel-fhir: Override commons-text version

essobedo commented on code in PR #8602:
URL: https://github.com/apache/camel/pull/8602#discussion_r1001460797


##########
components/camel-fhir/camel-fhir-api/pom.xml:
##########
@@ -40,6 +40,11 @@
             <groupId>org.apache.camel</groupId>
             <artifactId>camel-support</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.commons</groupId>
+            <artifactId>commons-text</artifactId>
+            <version>${commons-text-version}</version>
+        </dependency>

Review Comment:
   Even if it is not really necessary, I would tend to exclude it from `hapi-fhir-base` to make it clear that it is an override or at least add a comment to explain that it is an override because otherwise over time we could remove it by mistake since it is not directly called by the component. For the component, it is a runtime/transitive dependency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org