[jira] [Commented] (HIVE-9023) HiveHistoryImpl relies on removed counters to print num rows

["Szehon Ho (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-9023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304787#comment-14304787 ] 

Szehon Ho commented on HIVE-9023:
---------------------------------

Hi Naveen, mostly looks good, but I have two concerns.

1.  What about query that affects same-name table in different databases?  Is that taken care of?
2.  I am nervous about removing the side-effect of setting 'numRows = 0' in FileSinkOperator, better to not remove it unless it's absolutely sure not needed.

Thanks

> HiveHistoryImpl relies on removed counters to print num rows
> ------------------------------------------------------------
>
>                 Key: HIVE-9023
>                 URL: https://issues.apache.org/jira/browse/HIVE-9023
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.13.0, 0.14.0, 0.13.1, 0.14.1
>            Reporter: Slava Markeyev
>            Assignee: Naveen Gangam
>            Priority: Minor
>              Labels: regression
>         Attachments: HIVE-9023.patch
>
>
> HiveHistoryImpl still relies on the counters that were removed in HIVE-5982 to determine the number of rows loaded. This results in regression of functionality. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)