You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "luwei16 (via GitHub)" <gi...@apache.org> on 2023/12/26 08:24:33 UTC

[PR] [fix] (schema change) fix missing data bug in schema change (#28938) [doris]

luwei16 opened a new pull request, #29064:
URL: https://github.com/apache/doris/pull/29064

   branch-2.0 #28938 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix] (schema change) fix missing data bug in schema change (#28938) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29064:
URL: https://github.com/apache/doris/pull/29064#issuecomment-1869387713

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix] (schema change) fix missing data bug in schema change (#28938) [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #29064:
URL: https://github.com/apache/doris/pull/29064#issuecomment-1869950213

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix] (schema change) fix missing data bug in schema change (#28938) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29064:
URL: https://github.com/apache/doris/pull/29064#issuecomment-1869387738

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix] (schema change) fix missing data bug in schema change (#28938) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29064:
URL: https://github.com/apache/doris/pull/29064#issuecomment-1869364891

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix] (schema change) fix missing data bug in schema change (#28938) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29064:
URL: https://github.com/apache/doris/pull/29064#issuecomment-1869377115

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit b398d977f5a6734dfb2a9b849116a569f828ea35, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4731	4500	4490	4490
   q2	375	148	160	148
   q3	1486	1318	1241	1241
   q4	1148	973	905	905
   q5	3194	3182	3179	3179
   q6	255	133	135	133
   q7	1031	480	501	480
   q8	2248	2284	2230	2230
   q9	6725	6670	6693	6670
   q10	3199	3312	3283	3283
   q11	336	207	210	207
   q12	365	212	208	208
   q13	4566	3778	3797	3778
   q14	239	208	214	208
   q15	579	526	526	526
   q16	432	395	383	383
   q17	1042	761	615	615
   q18	7106	6736	6773	6736
   q19	1596	1598	1604	1598
   q20	565	305	307	305
   q21	3184	2807	2761	2761
   q22	373	303	308	303
   Total cold run time: 44775 ms
   Total hot run time: 40387 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4422	4427	4390	4390
   q2	274	165	169	165
   q3	3516	3494	3500	3494
   q4	2445	2410	2414	2410
   q5	5736	5737	5758	5737
   q6	248	125	128	125
   q7	2389	1911	1830	1830
   q8	3604	3620	3615	3615
   q9	9079	9008	9028	9008
   q10	3901	4016	4021	4016
   q11	493	362	364	362
   q12	778	603	597	597
   q13	4307	3545	3599	3545
   q14	295	260	259	259
   q15	570	519	509	509
   q16	510	460	454	454
   q17	1975	1970	1959	1959
   q18	8623	8204	8083	8083
   q19	1817	1830	1812	1812
   q20	2236	1955	1945	1945
   q21	6622	6234	6232	6232
   q22	538	474	462	462
   Total cold run time: 64378 ms
   Total hot run time: 61009 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix] (schema change) fix missing data bug in schema change (#28938) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29064:
URL: https://github.com/apache/doris/pull/29064#issuecomment-1869375437

   TeamCity be ut coverage result:
    Function Coverage: 36.58% (8556/23389) 
    Line Coverage: 28.65% (69573/242845)
    Region Coverage: 27.66% (35981/130095)
    Branch Coverage: 24.38% (18386/75410)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/b398d977f5a6734dfb2a9b849116a569f828ea35_b398d977f5a6734dfb2a9b849116a569f828ea35/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix] (schema change) fix missing data bug in schema change (#28938) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29064:
URL: https://github.com/apache/doris/pull/29064#issuecomment-1869953275

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix] (schema change) fix missing data bug in schema change (#28938) [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #29064:
URL: https://github.com/apache/doris/pull/29064


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix] (schema change) fix missing data bug in schema change (#28938) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29064:
URL: https://github.com/apache/doris/pull/29064#issuecomment-1869382767

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.96 seconds
    stream load tsv:          567 seconds loaded 74807831229 Bytes, about 125 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          32.7 seconds inserted 10000000 Rows, about 305K ops/s
    storage size: 17183485363 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix] (schema change) fix missing data bug in schema change (#28938) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29064:
URL: https://github.com/apache/doris/pull/29064#issuecomment-1869966773

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit f3a5e95ef0f776cfcf47df6be305b31215720359, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4726	4447	4459	4447
   q2	366	153	159	153
   q3	1482	1335	1211	1211
   q4	1156	1002	955	955
   q5	3175	3167	3162	3162
   q6	257	135	133	133
   q7	1054	499	497	497
   q8	2286	2284	2247	2247
   q9	6705	6683	6698	6683
   q10	3185	3280	3297	3280
   q11	317	195	214	195
   q12	355	209	209	209
   q13	4567	3786	3803	3786
   q14	242	211	213	211
   q15	577	519	517	517
   q16	440	380	392	380
   q17	1039	765	536	536
   q18	7125	6893	6923	6893
   q19	1664	1636	1653	1636
   q20	614	316	327	316
   q21	3293	2767	2755	2755
   q22	375	307	310	307
   Total cold run time: 45000 ms
   Total hot run time: 40509 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4396	4400	4395	4395
   q2	268	167	167	167
   q3	3511	3497	3492	3492
   q4	2426	2407	2406	2406
   q5	5744	5727	5711	5711
   q6	247	126	126	126
   q7	2391	1872	1884	1872
   q8	3606	3596	3597	3596
   q9	9028	8968	8962	8962
   q10	3902	3985	4009	3985
   q11	473	375	364	364
   q12	785	602	599	599
   q13	4293	3546	3517	3517
   q14	296	251	261	251
   q15	567	519	521	519
   q16	517	499	468	468
   q17	1963	1971	1932	1932
   q18	8760	8196	8285	8196
   q19	1852	1837	1851	1837
   q20	2262	1952	1940	1940
   q21	6622	6234	6203	6203
   q22	572	449	447	447
   Total cold run time: 64481 ms
   Total hot run time: 60985 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix] (schema change) fix missing data bug in schema change (#28938) [doris]

Posted by "luwei16 (via GitHub)" <gi...@apache.org>.
luwei16 commented on PR #29064:
URL: https://github.com/apache/doris/pull/29064#issuecomment-1869360543

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix] (schema change) fix missing data bug in schema change (#28938) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29064:
URL: https://github.com/apache/doris/pull/29064#issuecomment-1869970603

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.09 seconds
    stream load tsv:          566 seconds loaded 74807831229 Bytes, about 126 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.1 seconds inserted 10000000 Rows, about 355K ops/s
    storage size: 17184000966 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix] (schema change) fix missing data bug in schema change (#28938) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29064:
URL: https://github.com/apache/doris/pull/29064#issuecomment-1869962895

   TeamCity be ut coverage result:
    Function Coverage: 36.61% (8584/23448) 
    Line Coverage: 28.67% (69759/243352)
    Region Coverage: 27.64% (36061/130454)
    Branch Coverage: 24.35% (18416/75622)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/f3a5e95ef0f776cfcf47df6be305b31215720359_f3a5e95ef0f776cfcf47df6be305b31215720359/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org