[GitHub] [submarine] jiwq commented on a change in pull request #878: SUBMARINE-1187. Refine the interface of internal service and keep more details into db

[GitBox <gi...@apache.org>]

jiwq commented on a change in pull request #878:
URL: https://github.com/apache/submarine/pull/878#discussion_r808143115



##########
File path: submarine-server/server-core/pom.xml
##########
@@ -437,6 +437,11 @@
           <artifactId>jackson-annotations</artifactId>
         </exclusion>
       </exclusions>
+    </dependency>
+	<dependency>

Review comment:
       indentation nit~

##########
File path: submarine-server/server-core/pom.xml
##########
@@ -437,6 +437,11 @@
           <artifactId>jackson-annotations</artifactId>
         </exclusion>
       </exclusions>
+    </dependency>
+	<dependency>
+      <groupId>joda-time</groupId>
+      <artifactId>joda-time</artifactId>
+      <version>2.10.8</version>

Review comment:
       - should better move the dependency to center management
   - the artifact's version should define in property

##########
File path: submarine-server/server-core/src/main/java/org/apache/submarine/server/experiment/database/entity/ExperimentEntity.java
##########
@@ -19,6 +19,7 @@
 
 package org.apache.submarine.server.experiment.database.entity;
 
+

Review comment:
       redundant blank line




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org