[jira] [Commented] (THRIFT-3972) C++ Library NoStarveReadWriteMutex helgrind identified race

["James E. King, III (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15661563#comment-15661563 ] 

James E. King, III commented on THRIFT-3972:
--------------------------------------------

I decided to leave them all in the project for now.  If we decide to remove {{contrib/fb303}} in the future then ReadWriteMutex, NoStarveReadWriteMutex, and RWGuard can all be removed, simplifying maintenance of the project.

> C++ Library NoStarveReadWriteMutex helgrind identified race
> -----------------------------------------------------------
>
>                 Key: THRIFT-3972
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3972
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.10.0
>            Reporter: James E. King, III
>            Priority: Minor
>
> An issue from THRIFT-3038 was split out so it could be completed.
> There is a class in the project called NoStarveReadWriteMutex which is unused in the project.
> It has a unit test (RWMutexStarveTest).
> helgrind identified that there is a race in the handling of the volatile boolean in this class.
> I would prefer to just remove NoStarveReadWriteMutex as it is not used by the project, however doing so would require refactoring the RWMutexStarveTest because it ends up testing ReadWriteMutex, which is used by something in {{contrib/fb303}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)