You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/04/26 07:39:44 UTC

[GitHub] [rocketmq-client-go] ShannonDing commented on a change in pull request #427: [ISSUE #421] feat: support ipv6

ShannonDing commented on a change in pull request #427:
URL: https://github.com/apache/rocketmq-client-go/pull/427#discussion_r415243409



##########
File path: internal/remote/tcp_conn.go
##########
@@ -40,6 +48,19 @@ func initConn(ctx context.Context, addr string) (*tcpConnWrapper, error) {
 	}, nil
 }
 
+// reference by net.ParseIP
+func isIPV4(s string) bool {
+	for i := 0; i < len(s); i++ {
+		switch s[i] {
+		case '.':
+			return true

Review comment:
       for a domain like www.nameserver.com:8080, shall we consider it as an IPv4 string?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org