You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/21 12:18:53 UTC

[GitHub] [tvm] PhilippvK commented on pull request #9064: Ensure AOT passes all intermediary storages to function calls

PhilippvK commented on pull request #9064:
URL: https://github.com/apache/tvm/pull/9064#issuecomment-923928880


   The actual fix good to me! Thank you.
   
   One aspect I would like to mention before this is getting merged:
   
   This currently replaces the original `test_byoc_microtvm` test case by the one I come up with to reproduce the issue. I would suggest to add a second test case instead which uses multiple BYOC subgraphs. For this it would be helpful to replace the existing `CcompilerAnnotator `class with a generic one which is able to annotate any given model. Ideally the `MergeCompilerRegions` transformation should be enabled/diabled via pytest like this: `@pytest.mark.parametrize("merge_compiler_regions", [False, True])`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org