You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/09/12 16:44:50 UTC

[GitHub] [rocketmq] yazong opened a new pull request #2299: Modify cn RocketMQ_Example.md

yazong opened a new pull request #2299:
URL: https://github.com/apache/rocketmq/pull/2299


   ## What is the purpose of the change
   
   Symbol error in Chinese document
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #2299: Modify cn RocketMQ_Example.md

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2299:
URL: https://github.com/apache/rocketmq/pull/2299#issuecomment-691518100






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on pull request #2299: Modify cn RocketMQ_Example.md

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #2299:
URL: https://github.com/apache/rocketmq/pull/2299#issuecomment-692492642


   @yazong Firstly, plz submit related issues to link this PR and explain the purpose of PR according to the format.
   Second, you need change the target branch to develop.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #2299: Modify cn RocketMQ_Example.md

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2299:
URL: https://github.com/apache/rocketmq/pull/2299#issuecomment-691518100






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin closed pull request #2299: [ISSUE #XXXX] Modify cn RocketMQ_Example.md

Posted by GitBox <gi...@apache.org>.
RongtongJin closed pull request #2299:
URL: https://github.com/apache/rocketmq/pull/2299


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #2299: Modify cn RocketMQ_Example.md

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2299:
URL: https://github.com/apache/rocketmq/pull/2299#issuecomment-691517065


   
   [![Coverage Status](https://coveralls.io/builds/33413455/badge)](https://coveralls.io/builds/33413455)
   
   Coverage decreased (-0.04%) to 51.255% when pulling **51c9189ab8710db916cd4e90206b46158791a022 on yazong:master** into **9f95a972e10e0681bc3f2d00e9957aa212e897b5 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #2299: Modify cn RocketMQ_Example.md

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2299:
URL: https://github.com/apache/rocketmq/pull/2299#issuecomment-691517065






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #2299: Modify cn RocketMQ_Example.md

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2299:
URL: https://github.com/apache/rocketmq/pull/2299#issuecomment-691517065


   
   [![Coverage Status](https://coveralls.io/builds/33413455/badge)](https://coveralls.io/builds/33413455)
   
   Coverage decreased (-0.04%) to 51.255% when pulling **51c9189ab8710db916cd4e90206b46158791a022 on yazong:master** into **9f95a972e10e0681bc3f2d00e9957aa212e897b5 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #2299: Modify cn RocketMQ_Example.md

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2299:
URL: https://github.com/apache/rocketmq/pull/2299#issuecomment-691518100


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2299?src=pr&el=h1) Report
   > Merging [#2299](https://codecov.io/gh/apache/rocketmq/pull/2299?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq/commit/9f95a972e10e0681bc3f2d00e9957aa212e897b5?el=desc) will **decrease** coverage by `0.24%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/2299/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv)](https://codecov.io/gh/apache/rocketmq/pull/2299?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2299      +/-   ##
   ============================================
   - Coverage     45.68%   45.43%   -0.25%     
   + Complexity     4269     4249      -20     
   ============================================
     Files           546      546              
     Lines         35860    35860              
     Branches       4763     4763              
   ============================================
   - Hits          16381    16293      -88     
   - Misses        17434    17516      +82     
   - Partials       2045     2051       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2299?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/2299/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `41.79% <0.00%> (-8.96%)` | `16.00% <0.00%> (-3.00%)` | |
   | [...ketmq/client/impl/consumer/PullMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/2299/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `71.11% <0.00%> (-8.89%)` | `8.00% <0.00%> (-2.00%)` | |
   | [...org/apache/rocketmq/store/ha/WaitNotifyObject.java](https://codecov.io/gh/apache/rocketmq/pull/2299/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL1dhaXROb3RpZnlPYmplY3QuamF2YQ==) | `75.00% <0.00%> (-7.70%)` | `10.00% <0.00%> (-1.00%)` | |
   | [...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/2299/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=) | `38.98% <0.00%> (-6.50%)` | `16.00% <0.00%> (-3.00%)` | |
   | [...in/java/org/apache/rocketmq/test/util/MQAdmin.java](https://codecov.io/gh/apache/rocketmq/pull/2299/diff?src=pr&el=tree#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RQWRtaW4uamF2YQ==) | `38.88% <0.00%> (-5.56%)` | `7.00% <0.00%> (-1.00%)` | |
   | [...ain/java/org/apache/rocketmq/test/util/MQWait.java](https://codecov.io/gh/apache/rocketmq/pull/2299/diff?src=pr&el=tree#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RV2FpdC5qYXZh) | `43.24% <0.00%> (-5.41%)` | `3.00% <0.00%> (ø%)` | |
   | [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/2299/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | `57.67% <0.00%> (-5.12%)` | `31.00% <0.00%> (-1.00%)` | |
   | [...e/rocketmq/client/impl/consumer/RebalanceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2299/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VJbXBsLmphdmE=) | `50.99% <0.00%> (-4.39%)` | `34.00% <0.00%> (-2.00%)` | |
   | [...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/2299/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=) | `39.13% <0.00%> (-4.35%)` | `5.00% <0.00%> (-1.00%)` | |
   | [...ava/org/apache/rocketmq/test/util/VerifyUtils.java](https://codecov.io/gh/apache/rocketmq/pull/2299/diff?src=pr&el=tree#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL1ZlcmlmeVV0aWxzLmphdmE=) | `46.26% <0.00%> (-2.99%)` | `14.00% <0.00%> (-1.00%)` | |
   | ... and [10 more](https://codecov.io/gh/apache/rocketmq/pull/2299/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2299?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2299?src=pr&el=footer). Last update [9f95a97...51c9189](https://codecov.io/gh/apache/rocketmq/pull/2299?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #2299: Modify cn RocketMQ_Example.md

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2299:
URL: https://github.com/apache/rocketmq/pull/2299#issuecomment-691517065






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org