[GitHub] peng-yongsheng closed pull request #12: Use add data to set the values into remote data builder.

[GitBox <gi...@apache.org>]

peng-yongsheng closed pull request #12: Use add data to set the values into remote data builder.
URL: https://github.com/apache/incubator-skywalking-oal-tool/pull/12
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/oal-parser/src/main/resources/code-templates/IndicatorImplementor.ftl b/oal-parser/src/main/resources/code-templates/IndicatorImplementor.ftl
index 3245422..c073503 100644
--- a/oal-parser/src/main/resources/code-templates/IndicatorImplementor.ftl
+++ b/oal-parser/src/main/resources/code-templates/IndicatorImplementor.ftl
@@ -124,19 +124,19 @@ public class ${metricName}Indicator extends ${indicatorClassName} implements Ala
     @Override public RemoteData.Builder serialize() {
         RemoteData.Builder remoteBuilder = RemoteData.newBuilder();
 <#list serializeFields.stringFields as field>
-        remoteBuilder.setDataStrings(${field?index}, ${field.getter}());
+        remoteBuilder.addDataStrings(${field.getter}());
 </#list>
 
 <#list serializeFields.longFields as field>
-        remoteBuilder.setDataLongs(${field?index}, ${field.getter}());
+        remoteBuilder.addDataLongs(${field.getter}());
 </#list>
 
 <#list serializeFields.doubleFields as field>
-        remoteBuilder.setDataDoubles(${field?index}, ${field.getter}());
+        remoteBuilder.addDataDoubles(${field.getter}());
 </#list>
 
 <#list serializeFields.intFields as field>
-        remoteBuilder.setDataIntegers(${field?index}, ${field.getter}());
+        remoteBuilder.addDataIntegers(${field.getter}());
 </#list>
 <#list serializeFields.intLongValuePairListFields as field>
         ${field.getter}().forEach(element -> remoteBuilder.addDataIntLongPairList(element.serialize()));
diff --git a/oal-parser/src/test/resources/expectedFiles/IndicatorImplementorExpected.java b/oal-parser/src/test/resources/expectedFiles/IndicatorImplementorExpected.java
index b4554c4..febba5a 100644
--- a/oal-parser/src/test/resources/expectedFiles/IndicatorImplementorExpected.java
+++ b/oal-parser/src/test/resources/expectedFiles/IndicatorImplementorExpected.java
@@ -82,15 +82,15 @@
 
     @Override public RemoteData.Builder serialize() {
         RemoteData.Builder remoteBuilder = RemoteData.newBuilder();
-        remoteBuilder.setDataStrings(0, getEntityId());
-        remoteBuilder.setDataStrings(1, getStringField());
+        remoteBuilder.addDataStrings(getEntityId());
+        remoteBuilder.addDataStrings(getStringField());
 
-        remoteBuilder.setDataLongs(0, getSummation());
-        remoteBuilder.setDataLongs(1, getValue());
-        remoteBuilder.setDataLongs(2, getTimeBucket());
+        remoteBuilder.addDataLongs(getSummation());
+        remoteBuilder.addDataLongs(getValue());
+        remoteBuilder.addDataLongs(getTimeBucket());
 
 
-        remoteBuilder.setDataIntegers(0, getCount());
+        remoteBuilder.addDataIntegers(getCount());
 
         return remoteBuilder;
     }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services