You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Stephane Nicoll <st...@gmail.com> on 2005/11/09 18:48:38 UTC

resourceDir added in EAR plugin - duplicate with earSourceDirectory ?!

Hi guys,

I am about to fix some issues related to the EAR plugin and I am coming back
on an issue
http://jira.codehaus.org/browse/MNG-822

The purpose of MNG-822 is to make the M2 plugin compliant with M1 features.
This issue introduces (namely) an extra property

private File resourcesDir;

If set, content is copied in the generated EAR. If I go in the M1
documentation, I have

 maven.ear.resources Yes
 Directory that resources are copied to during the build.*NOTE:* cannot have
the same value of ${maven.ear.src}!
Before applying this change, we already had

private String earSourceDirectory;

Which does exactly that.

What am I missing? Brett, you applied the patch. Does it make any sense to
have two directories for extra resources (this is the situation right now?!)

Thanks,
Stéphane



--
.::You're welcome ::.

Re: resourceDir added in EAR plugin - duplicate with earSourceDirectory ?!

Posted by Brett Porter <br...@apache.org>.
I think this made it consistent, and the resourcesDir defaults to 
target/classes, but given there is already a work directory and I don't 
think anything else goes into target/classes so it is probably a no-op.

Unless there is something else, it is probably safe to deprecate it.

- Brett

Stephane Nicoll wrote:
> One last time :)
> 
> On 11/10/05, Stephane Nicoll <st...@gmail.com> wrote:
>> anyone?
>>
>> On 11/9/05, Stephane Nicoll <st...@gmail.com> wrote:
>>> Hi guys,
>>>
>>> I am about to fix some issues related to the EAR plugin and I am coming
>>> back on an issue
>>> http://jira.codehaus.org/browse/MNG-822
>>>
>>> The purpose of MNG-822 is to make the M2 plugin compliant with M1
>>> features. This issue introduces (namely) an extra property
>>>
>>> private File resourcesDir;
>>>
>>> If set, content is copied in the generated EAR. If I go in the M1
>>> documentation, I have
>>>
>>>  maven.ear.resources Yes
>>>  Directory that resources are copied to during the build.*NOTE:* cannot
>>> have the same value of ${maven.ear.src}!
>>> Before applying this change, we already had
>>>
>>> private String earSourceDirectory;
>>>
>>> Which does exactly that.
>>>
>>> What am I missing? Brett, you applied the patch. Does it make any sense
>>> to have two directories for extra resources (this is the situation right
>>> now?!)
>>>
>>> Thanks,
>>> Stéphane
>>>
>>>
>>>
>>> --
>>> .::You're welcome ::.
>>
>>
>>
>> --
>> .::You're welcome ::.
> 
> 
> 
> 
> --
> .::You're welcome ::.
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: resourceDir added in EAR plugin - duplicate with earSourceDirectory ?!

Posted by Stephane Nicoll <st...@gmail.com>.
One last time :)

On 11/10/05, Stephane Nicoll <st...@gmail.com> wrote:
>
> anyone?
>
> On 11/9/05, Stephane Nicoll <st...@gmail.com> wrote:
> >
> > Hi guys,
> >
> > I am about to fix some issues related to the EAR plugin and I am coming
> > back on an issue
> > http://jira.codehaus.org/browse/MNG-822
> >
> > The purpose of MNG-822 is to make the M2 plugin compliant with M1
> > features. This issue introduces (namely) an extra property
> >
> > private File resourcesDir;
> >
> > If set, content is copied in the generated EAR. If I go in the M1
> > documentation, I have
> >
> >  maven.ear.resources Yes
> >  Directory that resources are copied to during the build.*NOTE:* cannot
> > have the same value of ${maven.ear.src}!
> > Before applying this change, we already had
> >
> > private String earSourceDirectory;
> >
> > Which does exactly that.
> >
> > What am I missing? Brett, you applied the patch. Does it make any sense
> > to have two directories for extra resources (this is the situation right
> > now?!)
> >
> > Thanks,
> > Stéphane
> >
> >
> >
> > --
> > .::You're welcome ::.
>
>
>
>
> --
> .::You're welcome ::.




--
.::You're welcome ::.

Re: resourceDir added in EAR plugin - duplicate with earSourceDirectory ?!

Posted by Stephane Nicoll <st...@gmail.com>.
anyone?

On 11/9/05, Stephane Nicoll <st...@gmail.com> wrote:
>
> Hi guys,
>
> I am about to fix some issues related to the EAR plugin and I am coming
> back on an issue
> http://jira.codehaus.org/browse/MNG-822
>
> The purpose of MNG-822 is to make the M2 plugin compliant with M1
> features. This issue introduces (namely) an extra property
>
> private File resourcesDir;
>
> If set, content is copied in the generated EAR. If I go in the M1
> documentation, I have
>
>  maven.ear.resources Yes
>  Directory that resources are copied to during the build.*NOTE:* cannot
> have the same value of ${maven.ear.src}!
> Before applying this change, we already had
>
> private String earSourceDirectory;
>
> Which does exactly that.
>
> What am I missing? Brett, you applied the patch. Does it make any sense to
> have two directories for extra resources (this is the situation right now?!)
>
> Thanks,
> Stéphane
>
>
>
> --
> .::You're welcome ::.




--
.::You're welcome ::.