You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by zodvik <gi...@git.apache.org> on 2018/03/01 11:55:12 UTC

[GitHub] storm pull request #2582: STORM-2984: Add jitter in executor heartbeat

GitHub user zodvik opened a pull request:

    https://github.com/apache/storm/pull/2582

    STORM-2984: Add jitter in executor heartbeat

    The executorHeartbeatTimer is scheduled without jitter. In cases where state storage is Zookeeper and not pacemaker, introducing jitter will help spread out the I/O over time on Zookeeper. This will be helpful for large clusters.
    
    The jitter time is `worker.heartbeat.frequency.secs`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zodvik/storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2582.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2582
    
----
commit be071dd6435185c0bbcef31d30b93eb920659e10
Author: Nikhil Bafna <ni...@...>
Date:   2018-03-01T11:53:44Z

    STORM-2984: Add jitter in executor heartbeat

----


---

[GitHub] storm issue #2582: STORM-2984: Add jitter in executor heartbeat

Posted by zodvik <gi...@git.apache.org>.
Github user zodvik commented on the issue:

    https://github.com/apache/storm/pull/2582
  
    @HeartSaVioR 
    Makes sense. I'll close this PR.


---

[GitHub] storm pull request #2582: STORM-2984: Add jitter in executor heartbeat

Posted by zodvik <gi...@git.apache.org>.
Github user zodvik closed the pull request at:

    https://github.com/apache/storm/pull/2582


---

[GitHub] storm issue #2582: STORM-2984: Add jitter in executor heartbeat

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2582
  
    @zodvik 
    Thanks for the contribution! Btw, we're planning to change the heartbeat mechanism to RPC which should reduce overall ZK load, so I'd rather rely on new mechanism. Please take a look at #2433.
    
    I think the patch is still effective on 1.x version line. Could you raise a pull request on 1.x-branch?


---

[GitHub] storm issue #2582: STORM-2984: Add jitter in executor heartbeat

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2582
  
    @zodvik We may still want to apply this to 1.x version line. So if you struggled and the patch helped your case, please submit the patch against 1.x-branch.


---