You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/09/19 21:14:25 UTC

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #913: ORC-1005: Make that the java and C++ impl of determineEncoding in RLEV2 are consistent.

dongjoon-hyun commented on a change in pull request #913:
URL: https://github.com/apache/orc/pull/913#discussion_r711803940



##########
File path: c++/src/RleEncoderV2.cc
##########
@@ -276,6 +276,20 @@ void RleEncoderV2::preparePatchedBlob(EncodingOption& option) {
     }
 }
 
+/**
+ * Prepare for Direct or PatchedBase encoding
+ * compute zigZagLiterals and zzBits100p (Max number of encoding bits required)
+ * @return zigzagLiterals
+ */
+int64_t* RleEncoderV2::prepareForDirectOrPatchedBase(EncodingOption& option) {

Review comment:
       Thank you for this refactoring, @guiyanakuang .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org