You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/07/20 23:29:42 UTC
[kudu-CR] [client] remove C++11 extensions from exported header
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18764
Change subject: [client] remove C++11 extensions from exported header
......................................................................
[client] remove C++11 extensions from exported header
Changelist 708fdff19 included updates to the exported C++ header
write_op.h. The C++ client API is still kept C++98 compliant,
so C++11 extensions should not be present.
This patch reverts the changes in src/kudu/client/write_op.h
that 708fdff19 introduced.
This is a follow-up to 708fdff19073dbe9dc4eb9492551443aa38111f9.
Change-Id: I042ccaa76e424475dd2347505a611cdcab5c21d3
---
M src/kudu/client/write_op.h
1 file changed, 22 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/18764/1
--
To view, visit http://gerrit.cloudera.org:8080/18764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I042ccaa76e424475dd2347505a611cdcab5c21d3
Gerrit-Change-Number: 18764
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [client] remove C++11 extensions from exported header
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18764 )
Change subject: [client] remove C++11 extensions from exported header
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042ccaa76e424475dd2347505a611cdcab5c21d3
Gerrit-Change-Number: 18764
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 21 Jul 2022 15:01:17 +0000
Gerrit-HasComments: No
[kudu-CR] [client] remove C++11 extensions from exported header
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18764 )
Change subject: [client] remove C++11 extensions from exported header
......................................................................
[client] remove C++11 extensions from exported header
Changelist 708fdff19 included updates to the exported C++ header
write_op.h. The C++ client API is still kept C++98 compliant,
so C++11 extensions should not be present.
This patch reverts the changes in src/kudu/client/write_op.h
that 708fdff19 introduced.
This is a follow-up to 708fdff19073dbe9dc4eb9492551443aa38111f9.
Change-Id: I042ccaa76e424475dd2347505a611cdcab5c21d3
Reviewed-on: http://gerrit.cloudera.org:8080/18764
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/client/write_op.h
1 file changed, 22 insertions(+), 21 deletions(-)
Approvals:
Alexey Serbin: Verified
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I042ccaa76e424475dd2347505a611cdcab5c21d3
Gerrit-Change-Number: 18764
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [client] remove C++11 extensions from exported header
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [client] remove C++11 extensions from exported header
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I042ccaa76e424475dd2347505a611cdcab5c21d3
Gerrit-Change-Number: 18764
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [client] remove C++11 extensions from exported header
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18764 )
Change subject: [client] remove C++11 extensions from exported header
......................................................................
Patch Set 1: Verified+1
unrelated test failure (DEBUG): TabletCopyClientBasicTestModes/TabletCopyClientBasicTest.TestDownloadBlockMayFail/0
--
To view, visit http://gerrit.cloudera.org:8080/18764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042ccaa76e424475dd2347505a611cdcab5c21d3
Gerrit-Change-Number: 18764
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 21 Jul 2022 00:42:49 +0000
Gerrit-HasComments: No