You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/18 17:36:41 UTC
[GitHub] [superset] AAfghahi opened a new pull request, #20118: feat: Adding additional information to load_chart
AAfghahi opened a new pull request, #20118:
URL: https://github.com/apache/superset/pull/20118
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR splits the datasource into an id and a type for easier digestion for logger. I did not change 'datasource' in case current loggers are tracking that. I also did not add any variables to the function, instead relying on a simple split instead.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi closed pull request #20118: feat: Adding additional information to load_chart
Posted by GitBox <gi...@apache.org>.
AAfghahi closed pull request #20118: feat: Adding additional information to load_chart
URL: https://github.com/apache/superset/pull/20118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on pull request #20118: feat: Adding additional information to load_chart
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on PR #20118:
URL: https://github.com/apache/superset/pull/20118#issuecomment-1131845321
Closed because we moved the logic elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a diff in pull request #20118: feat: Adding additional information to load_chart
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on code in PR #20118:
URL: https://github.com/apache/superset/pull/20118#discussion_r876244483
##########
superset-frontend/src/components/Chart/chartAction.js:
##########
@@ -389,6 +389,7 @@ export function exploreJSON(
ownState,
});
+ const datasourceInfo = formData.datasource.split('__');
Review Comment:
changed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh commented on a diff in pull request #20118: feat: Adding additional information to load_chart
Posted by GitBox <gi...@apache.org>.
hughhhh commented on code in PR #20118:
URL: https://github.com/apache/superset/pull/20118#discussion_r876226880
##########
superset-frontend/src/components/Chart/chartAction.js:
##########
@@ -389,6 +389,7 @@ export function exploreJSON(
ownState,
});
+ const datasourceInfo = formData.datasource.split('__');
Review Comment:
nit: deconstruct `datasource` then use it in for the split and the payload:
```
const { datasource } = formData;
// ...
logEvent(LOG_ACTIONS_LOAD_CHART, {
// ...
datasource,
datasource_id: datasourceInfo[0],
datasource_type: datasourceInfo[1],
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org