You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "jira-importer (via GitHub)" <gi...@apache.org> on 2025/02/02 11:49:26 UTC

[I] [MJLINK-53] ITs should fail if no jlink binary is available [maven-jlink-plugin]

jira-importer opened a new issue, #325:
URL: https://github.com/apache/maven-jlink-plugin/issues/325

   **[Benjamin Marwell](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mampf86)** opened **[MJLINK-53](https://issues.apache.org/jira/browse/MJLINK-53?redirect=false)** and commented
   
   Currently the ITs will just be skipped if no jlink binary is available:
   
   ```java
   [INFO] --- maven-invoker-plugin:3.2.1:integration-test (integration-test) @ maven-jlink-plugin ---
   107[INFO] Running 2 setup jobs:
   108[INFO] Building: setup-jar-module-info/pom.xml
   109[INFO]           setup-jar-module-info/pom.xml .................... SKIPPED due to JRE version
   110[INFO] Building: setup-jar/pom.xml
   111[INFO]           setup-jar/pom.xml ................................ SKIPPED due to JRE version
   112[INFO] Setup done.
   113[INFO] Building: MJLINK-3_improveVerboseOutput/pom.xml
   114[INFO]           MJLINK-3_improveVerboseOutput/pom.xml ............ SKIPPED due to JRE version
   115[INFO] Building: MJLINK-4_dependencyResolution/pom.xml
   116[INFO]           MJLINK-4_dependencyResolution/pom.xml ............ SKIPPED due to JRE version
   117[INFO] Building: MJLINK-26/pom.xml
   118[INFO]           MJLINK-26/pom.xml ................................ SKIPPED due to JRE version
   119
   ```
   
   Source: https://github.com/bmarwell/maven-jlink-plugin/runs/1343140417?check_suite_focus=true#step:11:1
   
    
   
   However, building this project (maven-mjlink-plugin) with JDK8 should be supported using jlink via toolchains.
   
    
   
   To add a little bit more detail:
   
   https://issues.apache.org/jira/browse/MJLINK-36 is to be implemented via multi-module jars (e.g. add a folder `src/main/java9`). This means that without a Java8+Toolchain execution, the Java 8 code is never executed.
   
    
   
   
   ---
   
   **Remote Links:**
   - [GitHub Pull Request #21
   ](https://github.com/apache/maven-jlink-plugin/pull/21)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [MJLINK-53] ITs should fail if no jlink binary is available [maven-jlink-plugin]

Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #325:
URL: https://github.com/apache/maven-jlink-plugin/issues/325#issuecomment-2629361051

   **[Benjamin Marwell](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mampf86)** commented
   
   They do not fail, but a toolchain test has been added: https://github.com/apache/maven-jlink-plugin/pull/20
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org