You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/01/05 08:48:05 UTC
[GitHub] [rocketmq] cserwen opened a new issue #3702: [LICENSE] Add licenses for some files to pass the check of travis.
cserwen opened a new issue #3702:
URL: https://github.com/apache/rocketmq/issues/3702
**BUG REPORT**
1. Please describe the issue you observed:
- What did you do (The steps to reproduce)?
- What did you expect to see?
Can pass the check correctly
- What did you see instead?
`[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default-cli) on project rocketmq-common: Too many files with unapproved license: 2 `
2. Please tell us about your environment:
- MacOS
- 5.0.0-alpha
3. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):
```
Files with unapproved licenses:
src/test/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingUtilsTest.java
src/test/java/org/apache/rocketmq/common/statictopic/TopicQueueMappingTest.java
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] cserwen commented on issue #3702: [Code Style] Fix check style for branch: 5.0.0-alpha
Posted by GitBox <gi...@apache.org>.
cserwen commented on issue #3702:
URL: https://github.com/apache/rocketmq/issues/3702#issuecomment-1005589335
In addition to this problem, there are other problems. I have fix them in this pr. But what is more confused is that this branch does not care much about code checks? :confused:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky closed issue #3702: [Code Style] Fix check style for branch: 5.0.0-alpha
Posted by GitBox <gi...@apache.org>.
duhenglucky closed issue #3702:
URL: https://github.com/apache/rocketmq/issues/3702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] cserwen edited a comment on issue #3702: [Code Style] Fix check style for branch: 5.0.0-alpha
Posted by GitBox <gi...@apache.org>.
cserwen edited a comment on issue #3702:
URL: https://github.com/apache/rocketmq/issues/3702#issuecomment-1005589335
In addition to this problem, there are some other problems. I have fix them in this pr. But what is more confused is that this branch does not care much about code checks? :confused:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling commented on issue #3702: [Code Style] Fix check style for branch: 5.0.0-alpha
Posted by GitBox <gi...@apache.org>.
vongosling commented on issue #3702:
URL: https://github.com/apache/rocketmq/issues/3702#issuecomment-1006198612
Thanks @cserwen .
@duhenglucky @dongeforever Code is over than... Pls, pay more attention to @cserwen suggestion. we don't want to see any negative reviews about our next architecture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org