You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "HappyHacker123 (via GitHub)" <gi...@apache.org> on 2024/04/08 11:33:37 UTC
[PR] [TINKERPOP-3060] Manage the versions of snappy-java and jackson-* centrally to avoid version conflict. [tinkerpop]
HappyHacker123 opened a new pull request, #2546:
URL: https://github.com/apache/tinkerpop/pull/2546
Currently some modules of Tinkerpop are using the same dependency. However, some of these dependencies' versions are not centrally managed and therefore cause discrepancy. This pr defines version in parent pom.xml centrally to avoid version conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3060] Manage the versions of snappy-java and jackson-* centrally to avoid version conflict. [tinkerpop]
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #2546:
URL: https://github.com/apache/tinkerpop/pull/2546#issuecomment-2148166240
Hi @HappyHacker123, much apologies for the late reply. I gave it some more thoughts, and while this will be a great improvement, I don't think we are quite ready to centralize these dependencies yet. The complexity is mainly due to the way dependencies are currently managed that’s leading to conflicts and may require module-specific versions, especially in hadoop and spark modules (as you may see some of the code comments in the poms). We are looking to improve this systemically, but before a decision is reached I think we’ll hold off on this PR and close it for now.
If you are still interested and have thoughts or recommendations related to dependency management, chime into our discussions for [removing gremlin-shaded](https://lists.apache.org/thread/m7yvvz9zc69nzn0nr6vz0tdo3ggffoy6) and [JPMS](https://lists.apache.org/thread/vkvqcxn6t2lsgpfym7v3g3qvksrh3cwc). We'd love to see more opinions on these topics. Again, thank you for taking the time submitting this PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3060] Manage the versions of snappy-java and jackson-* centrally to avoid version conflict. [tinkerpop]
Posted by "HappyHacker123 (via GitHub)" <gi...@apache.org>.
HappyHacker123 commented on PR #2546:
URL: https://github.com/apache/tinkerpop/pull/2546#issuecomment-2042543921
@xiazcy @Cole-Greer Could you please help me review this pr? Many thanks :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3060] Manage the versions of snappy-java and jackson-* centrally to avoid version conflict. [tinkerpop]
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy closed pull request #2546: [TINKERPOP-3060] Manage the versions of snappy-java and jackson-* centrally to avoid version conflict.
URL: https://github.com/apache/tinkerpop/pull/2546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3060] Manage the versions of snappy-java and jackson-* centrally to avoid version conflict. [tinkerpop]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2546:
URL: https://github.com/apache/tinkerpop/pull/2546#issuecomment-2042581374
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2546?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 76.49%. Comparing base [(`9b46b67`)](https://app.codecov.io/gh/apache/tinkerpop/commit/9b46b6777d2fa250e41daacf2fa4554605aff53a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`8b1e8bd`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2546?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 54 commits behind head on 3.7-dev.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.7-dev #2546 +/- ##
=============================================
+ Coverage 76.14% 76.49% +0.34%
- Complexity 13152 13174 +22
=============================================
Files 1084 1059 -25
Lines 65160 61282 -3878
Branches 7285 7297 +12
=============================================
- Hits 49616 46876 -2740
+ Misses 12839 11892 -947
+ Partials 2705 2514 -191
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2546?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3060] Manage the versions of snappy-java and jackson-* centrally to avoid version conflict. [tinkerpop]
Posted by "HappyHacker123 (via GitHub)" <gi...@apache.org>.
HappyHacker123 commented on PR #2546:
URL: https://github.com/apache/tinkerpop/pull/2546#issuecomment-2045162964
Thanks for your response :) @xiazcy .
> Note that we are in the middle of a release so we'll hold off on any merging and I'll revisit this PR once the release is done.
Sure, I'm fully supportive of holding off the pr until after the release is completed :).
> I do want to take a closer look into other pom files that might be able to take advantage of this.
Actually i ran a check on the whole Tinkerpop project and found many other situation like this. If you need it, i'm happy to provide the whole list :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3060] Manage the versions of snappy-java and jackson-* centrally to avoid version conflict. [tinkerpop]
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #2546:
URL: https://github.com/apache/tinkerpop/pull/2546#issuecomment-2043393487
Thanks for the PR @HappyHacker123! I like the improvement for the dependency version management. I do want to take a closer look into other pom files that might be able to take advantage of this. Note that we are in the middle of a release so we'll hold off on any merging and I'll revisit once this PR the release is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org