You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/05/24 08:31:48 UTC
svn commit: r1890151 - in
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox:
cos/COSInputStream.java filter/DecodeResult.java
Author: tilman
Date: Mon May 24 08:31:47 2021
New Revision: 1890151
URL: http://svn.apache.org/viewvc?rev=1890151&view=rev
Log:
PDFBOX-4892: refactor risky code, as suggested by valerybokov
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSInputStream.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/DecodeResult.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSInputStream.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSInputStream.java?rev=1890151&r1=1890150&r2=1890151&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSInputStream.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSInputStream.java Mon May 24 08:31:47 2021
@@ -108,7 +108,7 @@ public final class COSInputStream extend
{
if (decodeResults.isEmpty())
{
- return DecodeResult.DEFAULT;
+ return DecodeResult.createDefault();
}
else
{
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/DecodeResult.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/DecodeResult.java?rev=1890151&r1=1890150&r2=1890151&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/DecodeResult.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/DecodeResult.java Mon May 24 08:31:47 2021
@@ -27,9 +27,6 @@ import org.apache.pdfbox.pdmodel.graphic
*/
public final class DecodeResult
{
- /** Default decode result. */
- public static final DecodeResult DEFAULT = new DecodeResult(new COSDictionary());
-
private final COSDictionary parameters;
private PDJPXColorSpace colorSpace;
@@ -45,6 +42,16 @@ public final class DecodeResult
}
/**
+ * Return a default DecodeResult.
+ *
+ * @return
+ */
+ public static DecodeResult createDefault()
+ {
+ return new DecodeResult(new COSDictionary());
+ }
+
+ /**
* Returns the stream parameters, repaired using the embedded stream data.
* @return the repaired stream parameters, or an empty dictionary
*/