You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/25 19:42:45 UTC
[GitHub] [pulsar] klwilson227 opened a new issue #8704: When upgrading to 2.7 Errors in apply-config-from-env.py prevent configuration files updates.
klwilson227 opened a new issue #8704:
URL: https://github.com/apache/pulsar/issues/8704
**Describe the bug**
The zookeeper configuration is applied into the config files via the apply-config-from-env.py. This process run into a error when processing the pulsar_env.sh that now contains lines other than value assignments and receives a fatal error, leaving the configurations in a unwritten state.
In addition the following additional bugs/enhancements will be fixed.
1) If environment variable values contain spaces (as in java parameters), the resulting value is not properly written into the updated file with quotes. So the resulting value may not be interpreted correctly.
2) The logging should not log the values of passwords. These values should be redacted.
**To Reproduce**
Steps to reproduce the behavior:
1. Start the docker image from a chart using helm. The chart configuration must run: bin/apply-config-from-env.py when starting the chart. StreamNative/chart project was used as a model in this case.
2. Review the log files. When processing the pulsar_env.sh the following lines are written.
itomdipulsar-zookeeper Traceback (most recent call last):
itomdipulsar-zookeeper File "bin/apply-config-from-env.py", line 50, in <module>
itomdipulsar-zookeeper k,v = line.split('=', 1)
itomdipulsar-zookeeper ValueError: not enough values to unpack (expected 2, got 1)
**Expected behavior**
Errors in parsing any lines should be ignored and the original line should be written out. The lines with values should be modified when there is a new value to insert.
**Screenshots**
N/A
**Desktop (please complete the following information):**
- OS: [e.g. iOS]
**Additional context**
Add any other context about the problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] klwilson227 commented on issue #8704: When upgrading to 2.7 Errors in apply-config-from-env.py prevent configuration files updates.
Posted by GitBox <gi...@apache.org>.
klwilson227 commented on issue #8704:
URL: https://github.com/apache/pulsar/issues/8704#issuecomment-733913053
I will post a PR for this shortly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie closed issue #8704: When upgrading to 2.7 Errors in apply-config-from-env.py prevent configuration files updates.
Posted by GitBox <gi...@apache.org>.
sijie closed issue #8704:
URL: https://github.com/apache/pulsar/issues/8704
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org