You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Stefan Seifert <ss...@pro-vision.de> on 2007/05/08 22:43:33 UTC
APP_CLASS_PARAM not static in ContextParamWebApplicationFactory?
hello.
it would be nice it the variable APP_CLASS_PARAM in class
org.apache.wicket.protocol.http.ContextParamWebApplicationFactory
can be marked as static, so it is easy to reference them when initializing the wicket servlet via code.
for now, it is marked as public and final, but not static.
patch included...
stefan
Re: APP_CLASS_PARAM not static in ContextParamWebApplicationFactory?
Posted by Eelco Hillenius <ee...@gmail.com>.
Done.
Eelco
> > > it would be nice it the variable APP_CLASS_PARAM in class
> > >
> > > org.apache.wicket.protocol.http.ContextParamWebApplicationFactory
> > >
> > > can be marked as static, so it is easy to reference them when initializing the wicket servlet via code.
> > > for now, it is marked as public and final, but not static.
> > >
> > > patch included...
> > >
> > > stefan
> > >
> >
>
Re: APP_CLASS_PARAM not static in ContextParamWebApplicationFactory?
Posted by Eelco Hillenius <ee...@gmail.com>.
Ugh. Strike that comment. I misread.
Eelco
On 5/8/07, Eelco Hillenius <ee...@gmail.com> wrote:
> But then there is
>
> final String applicationClassName = filter.getFilterConfig().getInitParameter(
> APP_CLASS_PARAM);
>
> I don't know why that has to be flexible though. Looks like bloat to
> me. Also, upper case should be for statics, so it's use here is wrong.
>
> Eelco
>
>
> On 5/8/07, Stefan Seifert <ss...@pro-vision.de> wrote:
> > hello.
> >
> > it would be nice it the variable APP_CLASS_PARAM in class
> >
> > org.apache.wicket.protocol.http.ContextParamWebApplicationFactory
> >
> > can be marked as static, so it is easy to reference them when initializing the wicket servlet via code.
> > for now, it is marked as public and final, but not static.
> >
> > patch included...
> >
> > stefan
> >
>
Re: APP_CLASS_PARAM not static in ContextParamWebApplicationFactory?
Posted by Eelco Hillenius <ee...@gmail.com>.
But then there is
final String applicationClassName = filter.getFilterConfig().getInitParameter(
APP_CLASS_PARAM);
I don't know why that has to be flexible though. Looks like bloat to
me. Also, upper case should be for statics, so it's use here is wrong.
Eelco
On 5/8/07, Stefan Seifert <ss...@pro-vision.de> wrote:
> hello.
>
> it would be nice it the variable APP_CLASS_PARAM in class
>
> org.apache.wicket.protocol.http.ContextParamWebApplicationFactory
>
> can be marked as static, so it is easy to reference them when initializing the wicket servlet via code.
> for now, it is marked as public and final, but not static.
>
> patch included...
>
> stefan
>