[GitHub] [airflow] Brett37490 commented on pull request #13923: Don't add Website.can_read access to default roles.

[GitBox <gi...@apache.org>]

Brett37490 commented on pull request #13923:
URL: https://github.com/apache/airflow/pull/13923#issuecomment-769500709


   he doesn't get paid til now
   
   On Thu, 28 Jan 2021, 05:54 James Timmins, <no...@github.com> wrote:
   
   > *@jhtimmins* commented on this pull request.
   > ------------------------------
   >
   > In airflow/www/security.py
   > <https://github.com/apache/airflow/pull/13923#discussion_r565554381>:
   >
   > > +        custom_roles = [role for role in self.get_all_roles() if role.name not in EXISTING_ROLES]
   > +        for role in custom_roles:
   >
   > @kaxil <https://github.com/kaxil> All roles except for Public will get
   > Website.can_read. This is just only added to custom roles explicitly,
   > since the default ones already have it. So mostly I just wanted to not give
   > Public that access.
   >
   > Still think it's worth adding a test to make sure that isn't available to
   > Public?
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/airflow/pull/13923#discussion_r565554381>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ARWZRE7PJO3YXYPJBA4PVQTS4BOOFANCNFSM4WUUHAWA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org