[GitHub] [doris] yiguolei commented on a diff in pull request #13088: [refractor](vectorized) refractor some insert_xxx functions

[GitBox <gi...@apache.org>]

yiguolei commented on code in PR #13088:
URL: https://github.com/apache/doris/pull/13088#discussion_r985072890


##########
be/src/vec/columns/predicate_column.h:
##########
@@ -134,17 +134,15 @@ class PredicateColumnType final : public COWHelper<IColumn, PredicateColumnType<
     }
 
     void insert_many_default_type(const char* data_ptr, size_t num) {
-        T* res_val_ptr = (T*)data.get_end_ptr();
-        memcpy(res_val_ptr, data_ptr, num * sizeof(T));
-        res_val_ptr += num;
-        data.set_end_ptr(res_val_ptr);

Review Comment:
   If not change end ptr, then the podarray's data size is not changed? Is it wrong?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org