You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@roller.apache.org by "Greg Huber (JIRA)" <ji...@apache.org> on 2009/11/19 14:48:39 UTC

[jira] Created: (ROL-1847) Theme reloading for developmet

Theme reloading for developmet
------------------------------

                 Key: ROL-1847
                 URL: https://issues.apache.org/jira/browse/ROL-1847
             Project: Roller
          Issue Type: Improvement
          Components: Theme specific
    Affects Versions: 5.0
            Reporter: Greg Huber
            Assignee: Roller Unassigned
            Priority: Minor
             Fix For: 5.0
         Attachments: patch_theme_reloading.txt

When developing a new velocity theme its a pain restarting the container for changes to take effect.  This patch will make auto reloading possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ROL-1847) Theme reloading for developmet

Posted by "Greg Huber (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ROL-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Greg Huber updated ROL-1847:
----------------------------

    Attachment: I18nDevUtils.java

To reload AppicationResources without restaring tomcat.

> Theme reloading for developmet
> ------------------------------
>
>                 Key: ROL-1847
>                 URL: https://issues.apache.org/jira/browse/ROL-1847
>             Project: Roller
>          Issue Type: Improvement
>          Components: Theme specific
>    Affects Versions: 5.0
>            Reporter: Greg Huber
>            Assignee: Roller Unassigned
>            Priority: Minor
>             Fix For: 5.0
>
>         Attachments: I18nDevUtils.java, patch_theme_reloading.txt
>
>
> When developing a new velocity theme its a pain restarting the container for changes to take effect.  This patch will make auto reloading possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (ROL-1847) Theme reloading for developmet

Posted by "Dave Johnson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ROL-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Johnson reassigned ROL-1847:
---------------------------------

    Assignee: Dave Johnson  (was: Roller Unassigned)

> Theme reloading for developmet
> ------------------------------
>
>                 Key: ROL-1847
>                 URL: https://issues.apache.org/jira/browse/ROL-1847
>             Project: Roller
>          Issue Type: Improvement
>          Components: Theme specific
>    Affects Versions: 5.0
>            Reporter: Greg Huber
>            Assignee: Dave Johnson
>            Priority: Minor
>             Fix For: 5.0
>
>         Attachments: I18nDevUtils.java, patch_theme_reloading.txt
>
>
> When developing a new velocity theme its a pain restarting the container for changes to take effect.  This patch will make auto reloading possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ROL-1847) Theme reloading for developmet

Posted by "Greg Huber (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ROL-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788722#action_12788722 ] 

Greg Huber commented on ROL-1847:
---------------------------------

Also, for completeness,

1. SearchServlet needs to be updated with the reload:

// do we need to force a specific locale for the request?
		 if(searchRequest.getLocale() == null && !website.isShowAllLangs()) {
		 searchRequest.setLocale(website.getLocale());
		 }
// Development only. Reload if theme has been modified
		if (themeReload) {
			try {

				ThemeManager manager = EventsFactory.getEvents()
						.getThemeManager();

				boolean reloaded = manager.reLoadThemeFromDisk(website
						.getEditorTheme());

				if (reloaded) {

					// Reload message bundle
					I18nDevUtils.reloadBundle(website.getLocaleInstance());
					
					// Sync pages also
					WebsitePageCache.getInstance().clear();
					SiteWideCache.getInstance().clear();
					
				}

			} catch (EventsException e) {
				// ignored
			}

		}

2.  To reload the AplicationResources see I18nDevUtils attached.  Works in Tomcat.

> Theme reloading for developmet
> ------------------------------
>
>                 Key: ROL-1847
>                 URL: https://issues.apache.org/jira/browse/ROL-1847
>             Project: Roller
>          Issue Type: Improvement
>          Components: Theme specific
>    Affects Versions: 5.0
>            Reporter: Greg Huber
>            Assignee: Roller Unassigned
>            Priority: Minor
>             Fix For: 5.0
>
>         Attachments: patch_theme_reloading.txt
>
>
> When developing a new velocity theme its a pain restarting the container for changes to take effect.  This patch will make auto reloading possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (ROL-1847) Theme reloading for developmet

Posted by "Dave Johnson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ROL-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Johnson resolved ROL-1847.
-------------------------------

    Resolution: Fixed

Author: snoopdave
Date: Sun Feb 28 19:10:13 2010
New Revision: 917255

URL: http://svn.apache.org/viewvc?rev=917255&view=rev
Log:
Theme reloading for development
https://issues.apache.org/jira/browse/ROL-1847

Thanks for the patch, Greg!

> Theme reloading for developmet
> ------------------------------
>
>                 Key: ROL-1847
>                 URL: https://issues.apache.org/jira/browse/ROL-1847
>             Project: Roller
>          Issue Type: Improvement
>          Components: Theme specific
>    Affects Versions: 5.0
>            Reporter: Greg Huber
>            Assignee: Dave Johnson
>            Priority: Minor
>             Fix For: 5.0
>
>         Attachments: I18nDevUtils.java, patch_theme_reloading.txt
>
>
> When developing a new velocity theme its a pain restarting the container for changes to take effect.  This patch will make auto reloading possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Work started: (ROL-1847) Theme reloading for developmet

Posted by "Dave Johnson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ROL-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on ROL-1847 started by Dave Johnson.

> Theme reloading for developmet
> ------------------------------
>
>                 Key: ROL-1847
>                 URL: https://issues.apache.org/jira/browse/ROL-1847
>             Project: Roller
>          Issue Type: Improvement
>          Components: Theme specific
>    Affects Versions: 5.0
>            Reporter: Greg Huber
>            Assignee: Dave Johnson
>            Priority: Minor
>             Fix For: 5.0
>
>         Attachments: I18nDevUtils.java, patch_theme_reloading.txt
>
>
> When developing a new velocity theme its a pain restarting the container for changes to take effect.  This patch will make auto reloading possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ROL-1847) Theme reloading for developmet

Posted by "Greg Huber (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ROL-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Greg Huber updated ROL-1847:
----------------------------

    Attachment: patch_theme_reloading.txt

You also need to delete the style sheet from the db (webpage file) for 
the weblog you are developing with, otherwise roller will use the db 
version rather than the theme version.  N.B. every time the stylesheet tab 
is selected in Design, it will copy a new version to the db!.

> Theme reloading for developmet
> ------------------------------
>
>                 Key: ROL-1847
>                 URL: https://issues.apache.org/jira/browse/ROL-1847
>             Project: Roller
>          Issue Type: Improvement
>          Components: Theme specific
>    Affects Versions: 5.0
>            Reporter: Greg Huber
>            Assignee: Roller Unassigned
>            Priority: Minor
>             Fix For: 5.0
>
>         Attachments: patch_theme_reloading.txt
>
>
> When developing a new velocity theme its a pain restarting the container for changes to take effect.  This patch will make auto reloading possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.