You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2023/01/18 07:01:23 UTC
[GitHub] [incubator-seatunnel] 2000liux opened a new pull request, #3975: feat([Improve][Connector] cdc same code extraction, ConfigurationOption formatting
2000liux opened a new pull request, #3975:
URL: https://github.com/apache/incubator-seatunnel/pull/3975
## Purpose of this pull request
- When constructing MySql, SqlServer, and SourceConfig, some repeated string keys appear directly in the code
- The JdbcSourceOptions class in the connector-cdc-base module is a public options class, and the PORT field attribute defaults to 3306. This port is only used by mysql, and other databases may have some hidden dangers when using this key.
- I found that there may be inelegant writing in the code of some options
#### issue: [here](https://github.com/apache/incubator-seatunnel/issues/3971)
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] 2000liux commented on pull request #3975: [Improve][Connector] CDC same code extraction, ConfigurationOption formatting
Posted by "2000liux (via GitHub)" <gi...@apache.org>.
2000liux commented on PR #3975:
URL: https://github.com/apache/incubator-seatunnel/pull/3975#issuecomment-1406144075
issue: `Exception in thread "main" javax.net.ssl.SSLHandshakeException: Remote host terminated the handshake` .
please tell me how to solve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] 2000liux commented on pull request #3975: [Improve][Connector] CDC same code extraction, ConfigurationOption formatting
Posted by GitBox <gi...@apache.org>.
2000liux commented on PR #3975:
URL: https://github.com/apache/incubator-seatunnel/pull/3975#issuecomment-1387072476
checksytle checks and repairs illegal code, approves rerun workflows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] 2000liux commented on pull request #3975: [Improve][Connector] CDC same code extraction, ConfigurationOption formatting
Posted by "2000liux (via GitHub)" <gi...@apache.org>.
2000liux commented on PR #3975:
URL: https://github.com/apache/incubator-seatunnel/pull/3975#issuecomment-1399251389
Excuse me, where is this pr blocking now？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] 2000liux commented on pull request #3975: [Improve][Connector] CDC same code extraction, ConfigurationOption formatting
Posted by GitBox <gi...@apache.org>.
2000liux commented on PR #3975:
URL: https://github.com/apache/incubator-seatunnel/pull/3975#issuecomment-1396357948
- Hello, everyone. What can I do when this problem arises?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] 2000liux closed pull request #3975: [Improve][Connector] CDC same code extraction, ConfigurationOption formatting
Posted by "2000liux (via GitHub)" <gi...@apache.org>.
2000liux closed pull request #3975: [Improve][Connector] CDC same code extraction, ConfigurationOption formatting
URL: https://github.com/apache/incubator-seatunnel/pull/3975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org