You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/12 19:50:59 UTC

[GitHub] [camel-kafka-connector] valdar commented on a change in pull request #576: ISSUE-146 Prevent the overwrite of existing classes unless they are @Generated annotated

valdar commented on a change in pull request #576:
URL: https://github.com/apache/camel-kafka-connector/pull/576#discussion_r503499654



##########
File path: tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/utils/MavenUtils.java
##########
@@ -272,7 +273,18 @@ public static void writeSourceIfChanged(JavaClass source, String fileName, boole
 
     public static void writeSourceIfChanged(String source, String fileName, File baseDir, File javaFileHeader) throws MojoFailureException {
         //TODO: Do not write class if a class already exist and has no @generated annotation.

Review comment:
       can you remove the TODO?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org