[GitHub] [apisix-docker] leslie-tsang commented on a change in pull request #219: feat: more human friendly makefile output

[GitBox <gi...@apache.org>]

leslie-tsang commented on a change in pull request #219:
URL: https://github.com/apache/apisix-docker/pull/219#discussion_r706959375



##########
File path: Makefile
##########
@@ -24,69 +28,131 @@ APISIX_DASHBOARD_VERSION ?= 2.8
 APISIX_DASHBOARD_IMAGE_NAME = apache/apisix-dashboard
 APISIX_DASHBOARD_IMAGE_TAR_NAME = apache_apisix_dashboard
 
-### build-on-centos:      Build apache/apisix:xx-centos image
+
+# Makefile ENV
+ENV_OS_NAME                ?= $(shell uname -s | tr '[:upper:]' '[:lower:]')
+ENV_APISIX_TAR_NAME        ?= $(IMAGE_TAR_NAME)_$(APISIX_VERSION)
+ENV_APISIX_IMAGE_TAG_NAME  ?= $(IMAGE_NAME):$(APISIX_VERSION)
+ENV_DOCKER                 ?= docker
+
+
+# Makefile basic extension function
+_color_red    =\E[1;31m
+_color_green  =\E[1;32m
+_color_yellow =\E[1;33m
+_color_blue   =\E[1;34m
+_color_wipe   =\E[0m
+
+
+define func_echo_status
+	printf "[$(_color_blue) info $(_color_wipe)] %s\n" $(1)
+endef
+
+
+define func_echo_warn_status
+	printf "[$(_color_yellow) info $(_color_wipe)] %s\n" $(1)
+endef

Review comment:
       These two functions are reserved for better extend support




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org