[GitHub] [beam] pabloem commented on a diff in pull request #26699: Add BigTable batch size and latency metrics for writes

["pabloem (via GitHub)" <gi...@apache.org>]

pabloem commented on code in PR #26699:
URL: https://github.com/apache/beam/pull/26699#discussion_r1195335897


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java:
##########
@@ -548,6 +566,7 @@ public CompletionStage<MutateRowResponse> writeRecord(KV<ByteString, Iterable<Mu
 
       CompletableFuture<MutateRowResponse> result = new CompletableFuture<>();
 
+      outstandingMutations += 1;

Review Comment:
   thanks Bruno - yes, I was wondering that too, ha - since we create one per bundle, I don't think there's multiple concurrent calls to this logic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org