You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/24 17:31:29 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #31635: [SPARK-34518][SQL] Rename `AlterTableRecoverPartitionsCommand` to `RepairTableCommand`

cloud-fan commented on a change in pull request #31635:
URL: https://github.com/apache/spark/pull/31635#discussion_r582158363



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala
##########
@@ -600,11 +600,11 @@ case class PartitionStatistics(numFiles: Int, totalSize: Long)
  *   MSCK REPAIR TABLE table [{ADD|DROP|SYNC} PARTITIONS];
  * }}}
  */
-case class AlterTableRecoverPartitionsCommand(
+case class RepairTableCommand(

Review comment:
       I'm a bit reluctant to rename v1 commands, as they are legacy and have been there for many years. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org