You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/03/18 16:56:11 UTC

[GitHub] [trafficcontrol] anna-k-1 commented on a change in pull request #3383: Made PR template checklist check-able by ALL PRs

anna-k-1 commented on a change in pull request #3383: Made PR template checklist check-able by ALL PRs
URL: https://github.com/apache/trafficcontrol/pull/3383#discussion_r266542380
 
 

 ##########
 File path: PULL_REQUEST_TEMPLATE.md
 ##########
 @@ -1,52 +1,75 @@
-## Which issue is fixed by this PR? If not related to an existing issue, what does this PR do?
+## What does this PR (Pull Request) do?
+<!-- Explain the changes you made here. If this fixes an Issue, identify it by
+number e.g.
 
-Fixes #(replace_this_text_with_issue_number) 
+Fixes #9001
 
 Review comment:
   I think people do often forget to link the PR to an issue. In my template PR, I changed it from 'Fixes #(issue_number)' to  'Fixes #(replace_this_text_with_issue_number)' hoping to get more people to fill in the blank. Maybe we should also make this a checklist option? Just throwing an idea out there:
   
   This PR fixes an issue #(Issue Number Here)
   This PR adds a new feature
   Other 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services