You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/07/16 23:52:13 UTC
[GitHub] [cordova-android] raphinesse commented on issue #784: Properly
handle promise in create script
raphinesse commented on issue #784: Properly handle promise in create script
URL: https://github.com/apache/cordova-android/pull/784#issuecomment-512044421
> I do find it _really_ interesting that the tests, including the `validateProjectName` failure tests, did pass with this promise not properly handled. I am suspecting that this would not have been the case when using standard JavaScript promises.
The `validateProjectName` failure tests never execute that code. It's part of `exports.create`. The tests for `exports.create` OTOH stub `validateProjectName` and only verify that it has been called. So this couldn't have failed any of the existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org