You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Joe Orton <jo...@redhat.com> on 2022/08/18 11:31:56 UTC
[VOTE] Release libapreq2-2.17
Hi, I've prepared a candidate release tarball for libapreq2 v2.17 here:
https://dist.apache.org/repos/dist/dev/httpd/libapreq/
I would like to call a VOTE over the next week to release this candidate
tarball as v2.17:
[ ] +1: It's not just good, it's good enough!
[ ] +0: Let's have a talk.
[ ] -1: There's trouble in paradise. Here's what's wrong.
SHA-256 and SHA-512 checksums for the tarball are as follows:
046487f084c12fa1c822affc5f7de56efed9b48905a426e631a6b949c114d86c libapreq2-2.17.tar.gz
89b139b8673145d9e2d8fd77d36f878c519c1deb7f9b853cda2a15d34cbb619d1c5e784ba21553f23c2ef07803f07c75a83d96cd770f80e1b36283a4cbb88999 libapreq2-2.17.tar.gz
The release is prepared from:
https://svn.apache.org/repos/asf/httpd/apreq/branches/v2.17 at r1903514
Regards, Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [VOTE] Release libapreq2-2.17
Posted by Yann Ylavic <yl...@gmail.com>.
On Mon, Aug 22, 2022 at 11:32 AM Yann Ylavic <yl...@gmail.com> wrote:
>
> On Thu, Aug 18, 2022 at 1:32 PM Joe Orton <jo...@redhat.com> wrote:
> >
> > I would like to call a VOTE over the next week to release this candidate
> > tarball as v2.17:
>
> +1 on Debian(s).
Not really related to apreq, but somehow the perl test framework is
now generating certificate key files in PKCS#8 format (for
SSLProxyMachineCertificateFile), previously they were in PKCS#1
format. That's the case for the httpd test framework too.
Any idea what happened there?
As a result load_x509_info()::PEM_X509_INFO_read_bio() does not
recognize them as private key files and httpd-2.4.x fails to load.
httpd-trunk is loading still, thanks to r1884552, but this commit
looks quite orthogonal/incidental per the commit message?
Linking httpd-trunk with libapreq seems useless/hopeless though, since
the apreq util/helper functions have been copied in server/apreq_*.c
files with the exact same apreq_ prefix, httpd will always use its own
ones..
Regards;
Yann.
Re: [VOTE] Release libapreq2-2.17
Posted by Yann Ylavic <yl...@gmail.com>.
On Mon, Aug 22, 2022 at 11:32 AM Yann Ylavic <yl...@gmail.com> wrote:
>
> On Thu, Aug 18, 2022 at 1:32 PM Joe Orton <jo...@redhat.com> wrote:
> >
> > I would like to call a VOTE over the next week to release this candidate
> > tarball as v2.17:
>
> +1 on Debian(s).
Not really related to apreq, but somehow the perl test framework is
now generating certificate key files in PKCS#8 format (for
SSLProxyMachineCertificateFile), previously they were in PKCS#1
format. That's the case for the httpd test framework too.
Any idea what happened there?
As a result load_x509_info()::PEM_X509_INFO_read_bio() does not
recognize them as private key files and httpd-2.4.x fails to load.
httpd-trunk is loading still, thanks to r1884552, but this commit
looks quite orthogonal/incidental per the commit message?
Linking httpd-trunk with libapreq seems useless/hopeless though, since
the apreq util/helper functions have been copied in server/apreq_*.c
files with the exact same apreq_ prefix, httpd will always use its own
ones..
Regards;
Yann.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [VOTE] Release libapreq2-2.17
Posted by Yann Ylavic <yl...@gmail.com>.
On Thu, Aug 18, 2022 at 1:32 PM Joe Orton <jo...@redhat.com> wrote:
>
> I would like to call a VOTE over the next week to release this candidate
> tarball as v2.17:
+1 on Debian(s).
Thanks Joe for RMIng!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [VOTE] Release libapreq2-2.17
Posted by "Edward J. Sabol" <ed...@gmail.com>.
On Aug 25, 2022, at 4:30 AM, Joe Orton <jo...@redhat.com> wrote:
> On Sun, Aug 21, 2022 at 04:28:25PM -0400, Edward J. Sabol wrote:
>> "make test" reported no errors. However, the following tests were skipped:
>>
>> t/cgi.t .......... skipped: cannot find one of cgi.c or cgid.c
>>
>> t/apreq/cgi.t ........ skipped: cannot find one of cgi.c or cgid.c
>>
>> Any ideas as to why or what I should investigate or do to fix that, assuming it's indicative of a problem?
>
> Do you have mod_cgi or mod_cgid built and loaded in the httpd install
> you are testing against? These tests should get skipped if not, which is
> perfectly normal/expected.
Thanks for your reply, Joe. That's reassuring. I see a mod_cgi.so in the same directory where mod_apreq.so is installed, but I guess Apache::Test isn't finding it or loading it for whatever reason.
Cheers on the libapreq2-2.17 release!
Regards,
Ed
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [VOTE] Release libapreq2-2.17
Posted by Joe Orton <jo...@redhat.com>.
On Sun, Aug 21, 2022 at 04:28:25PM -0400, Edward J. Sabol wrote:
> "make test" reported no errors. However, the following tests were skipped:
>
> t/cgi.t .......... skipped: cannot find one of cgi.c or cgid.c
>
> t/apreq/cgi.t ........ skipped: cannot find one of cgi.c or cgid.c
>
> Any ideas as to why or what I should investigate or do to fix that, assuming it's indicative of a problem?
Hi Edward,
Do you have mod_cgi or mod_cgid built and loaded in the httpd install
you are testing against? These tests should get skipped if not, which is
perfectly normal/expected.
Regards, Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [VOTE] Release libapreq2-2.17
Posted by "Edward J. Sabol" <ed...@gmail.com>.
Hi, Joe O.!
On Aug 18, 2022, at 7:31 AM, Joe Orton <jo...@redhat.com> wrote:
> https://dist.apache.org/repos/dist/dev/httpd/libapreq/
I successfully configured and compiled using the following command:
./configure --enable-perl-glue --with-apache2-apxs=/path/to/my/apxs --with-perl=/path/to/some/perl "CFLAGS=-m32" "CXXFLAGS=-m32" "LDFLAGS=-m32"
(Yeah, I'm compiling a 32-bit version because of institutional inertia and other esoteric reasons.)
"make test" reported no errors. However, the following tests were skipped:
t/cgi.t .......... skipped: cannot find one of cgi.c or cgid.c
t/apreq/cgi.t ........ skipped: cannot find one of cgi.c or cgid.c
Any ideas as to why or what I should investigate or do to fix that, assuming it's indicative of a problem?
Thanks,
Ed
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [VOTE] Release libapreq2-2.17
Posted by Joe Orton <jo...@redhat.com>.
On Thu, Aug 18, 2022 at 12:31:56PM +0100, Joe Orton wrote:
> Hi, I've prepared a candidate release tarball for libapreq2 v2.17 here:
>
> https://dist.apache.org/repos/dist/dev/httpd/libapreq/
>
> I would like to call a VOTE over the next week to release this candidate
> tarball as v2.17:
>
> [X] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
Adding my own +1, tests fine here on Fedora 36.
Regards, Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [VOTE] Release libapreq2-2.17
Posted by jean-frederic clere <jf...@gmail.com>.
On 8/18/22 13:31, Joe Orton wrote:
> [X] +1: It's not just good, it's good enough!
Tested on fedora 36
--
Cheers
Jean-Frederic
Re: [VOTE] Release libapreq2-2.17
Posted by Joe Orton <jo...@redhat.com>.
On Thu, Aug 18, 2022 at 12:31:56PM +0100, Joe Orton wrote:
> Hi, I've prepared a candidate release tarball for libapreq2 v2.17 here:
>
> https://dist.apache.org/repos/dist/dev/httpd/libapreq/
>
> I would like to call a VOTE over the next week to release this candidate
> tarball as v2.17:
>
> [X] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
Adding my own +1, tests fine here on Fedora 36.
Regards, Joe
Re: [RESULT: PASS] [VOTE] Release libapreq2-2.17
Posted by Ed Sabol <ed...@gmail.com>.
On Oct 12, 2022, at 9:47 AM, Yann Ylavic <yl...@gmail.com> wrote:
>
> On Thu, Sep 29, 2022 at 1:16 PM Steve Hay <st...@googlemail.com> wrote:
>>
>> On Thu, 25 Aug 2022 at 09:58, Joe Orton <jo...@redhat.com> wrote:
>>>
>>> Thanks for testing. The release is approved:
>>>
>>> PMC votes: +1 from ylavic, jfclere, jorton
>>>
>>> I will promote the release and announce it.
>>>
>>
>> Thanks for this release. I didn't get round to uploading it to CPAN
>> yet, but a bug report has come in for it anyway:
>>
>> https://rt.cpan.org/Public/Bug/Display.html?id=144470
>
> Do we have an example of a payload/upload which does not pass apreq's
> multipart parsing in 2.17?
I think the reporter is saying any zero-length file will trigger the hang? Have you tried testing multipart uploads with one of the uploads being a zero-length file, Yann?
I've looked over the diffs between 2.16 and 2.17. I noticed that several loops in consume_header_line() in library/parser_header.c have changed from
while (nlen > 0) { ... }
to
do { ... } while (nlen > 0);
(including glen and other variants) and the following lines were removed:
if (nlen == 0)
return APR_EBADARG;
With little familiarity with the code, I naively wonder if either or both of those might be the cause since the nlen == 0 case may not be handled now?
Of course, I would really expect the problem to be in library/parser_multipart.c, and there are lots of changes there but nothing that caught my eye as someone unfamiliar with the code.
Thanks,
Ed
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [RESULT: PASS] Re: [VOTE] Release libapreq2-2.17
Posted by Yann Ylavic <yl...@gmail.com>.
On Thu, Sep 29, 2022 at 1:16 PM Steve Hay <st...@googlemail.com> wrote:
>
> On Thu, 25 Aug 2022 at 09:58, Joe Orton <jo...@redhat.com> wrote:
> >
> > Thanks for testing. The release is approved:
> >
> > PMC votes: +1 from ylavic, jfclere, jorton
> >
> > I will promote the release and announce it.
> >
>
> Thanks for this release. I didn't get round to uploading it to CPAN
> yet, but a bug report has come in for it anyway:
>
> https://rt.cpan.org/Public/Bug/Display.html?id=144470
Do we have an example of a payload/upload which does not pass apreq's
multipart parsing in 2.17?
Regards;
Yann.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [RESULT: PASS] Re: [VOTE] Release libapreq2-2.17
Posted by Yann Ylavic <yl...@gmail.com>.
On Thu, Sep 29, 2022 at 1:16 PM Steve Hay <st...@googlemail.com> wrote:
>
> On Thu, 25 Aug 2022 at 09:58, Joe Orton <jo...@redhat.com> wrote:
> >
> > Thanks for testing. The release is approved:
> >
> > PMC votes: +1 from ylavic, jfclere, jorton
> >
> > I will promote the release and announce it.
> >
>
> Thanks for this release. I didn't get round to uploading it to CPAN
> yet, but a bug report has come in for it anyway:
>
> https://rt.cpan.org/Public/Bug/Display.html?id=144470
Do we have an example of a payload/upload which does not pass apreq's
multipart parsing in 2.17?
Regards;
Yann.
Re: [RESULT: PASS] Re: [VOTE] Release libapreq2-2.17
Posted by Steve Hay <st...@googlemail.com.INVALID>.
On Thu, 25 Aug 2022 at 09:58, Joe Orton <jo...@redhat.com> wrote:
>
> Thanks for testing. The release is approved:
>
> PMC votes: +1 from ylavic, jfclere, jorton
>
> I will promote the release and announce it.
>
Thanks for this release. I didn't get round to uploading it to CPAN
yet, but a bug report has come in for it anyway:
https://rt.cpan.org/Public/Bug/Display.html?id=144470
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [RESULT: PASS] Re: [VOTE] Release libapreq2-2.17
Posted by Steve Hay <st...@googlemail.com>.
On Thu, 25 Aug 2022 at 09:58, Joe Orton <jo...@redhat.com> wrote:
>
> Thanks for testing. The release is approved:
>
> PMC votes: +1 from ylavic, jfclere, jorton
>
> I will promote the release and announce it.
>
Thanks for this release. I didn't get round to uploading it to CPAN
yet, but a bug report has come in for it anyway:
https://rt.cpan.org/Public/Bug/Display.html?id=144470
[RESULT: PASS] Re: [VOTE] Release libapreq2-2.17
Posted by Joe Orton <jo...@redhat.com>.
Thanks for testing. The release is approved:
PMC votes: +1 from ylavic, jfclere, jorton
I will promote the release and announce it.
Regards, Joe
Re: [VOTE] Release libapreq2-2.17
Posted by Yann Ylavic <yl...@gmail.com>.
On Thu, Aug 18, 2022 at 1:32 PM Joe Orton <jo...@redhat.com> wrote:
>
> I would like to call a VOTE over the next week to release this candidate
> tarball as v2.17:
+1 on Debian(s).
Thanks Joe for RMIng!
[RESULT: PASS] Re: [VOTE] Release libapreq2-2.17
Posted by Joe Orton <jo...@redhat.com>.
Thanks for testing. The release is approved:
PMC votes: +1 from ylavic, jfclere, jorton
I will promote the release and announce it.
Regards, Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [VOTE] Release libapreq2-2.17
Posted by jean-frederic clere <jf...@gmail.com>.
On 8/18/22 13:31, Joe Orton wrote:
> [X] +1: It's not just good, it's good enough!
Tested on fedora 36
--
Cheers
Jean-Frederic
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org