You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/15 04:26:56 UTC
[GitHub] [dolphinscheduler] EricPyZhou opened a new issue, #12901: [Improvement][Resource Center] Return empty list instead of throwing errors when detecting no path existed for a tenant resource path
EricPyZhou opened a new issue, #12901:
URL: https://github.com/apache/dolphinscheduler/issues/12901
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
In the current implementation, we throw a general error when a tenant resource path is not found in a file system. Based on suggestions from @SbloodyS , Returning empty lists for tenants that don't have resource path is a better implementation and will give users a smoother experience.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou commented on issue #12901: [Improvement][Resource Center] Return empty list instead of throwing errors when detecting no path existed for a tenant resource path
Posted by GitBox <gi...@apache.org>.
EricPyZhou commented on issue #12901:
URL: https://github.com/apache/dolphinscheduler/issues/12901#issuecomment-1318008572
> I think we should return the message like [#12664 (comment)](https://github.com/apache/dolphinscheduler/pull/12664#discussion_r1022548800) when landing on resource center without having a tenant resource path created. @EricPyZhou
ah okay, so the behaviours are different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #12901: [Improvement][Resource Center] Return empty list instead of throwing errors when detecting no path existed for a tenant resource path
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #12901: [Improvement][Resource Center] Return empty list instead of throwing errors when detecting no path existed for a tenant resource path
URL: https://github.com/apache/dolphinscheduler/issues/12901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #12901: [Improvement][Resource Center] Return empty list instead of throwing errors when detecting no path existed for a tenant resource path
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #12901:
URL: https://github.com/apache/dolphinscheduler/issues/12901#issuecomment-1314755949
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #12901: [Improvement][Resource Center] Return empty list instead of throwing errors when detecting no path existed for a tenant resource path
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #12901:
URL: https://github.com/apache/dolphinscheduler/issues/12901#issuecomment-1356518508
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #12901: [Improvement][Resource Center] Return empty list instead of throwing errors when detecting no path existed for a tenant resource path
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #12901:
URL: https://github.com/apache/dolphinscheduler/issues/12901#issuecomment-1364600257
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #12901: [Improvement][Resource Center] Return empty list instead of throwing errors when detecting no path existed for a tenant resource path
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #12901:
URL: https://github.com/apache/dolphinscheduler/issues/12901#issuecomment-1318006443
I think we should return the message like https://github.com/apache/dolphinscheduler/pull/12664#discussion_r1022548800 when landing on resource center without having a tenant resource path created. @EricPyZhou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #12901: [Improvement][Resource Center] Return empty list instead of throwing errors when detecting no path existed for a tenant resource path
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #12901:
URL: https://github.com/apache/dolphinscheduler/issues/12901#issuecomment-1316813198
I think simply just return an empty data list is ok since this is only the task instance definition, not the resource center.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou commented on issue #12901: [Improvement][Resource Center] Return empty list instead of throwing errors when detecting no path existed for a tenant resource path
Posted by GitBox <gi...@apache.org>.
EricPyZhou commented on issue #12901:
URL: https://github.com/apache/dolphinscheduler/issues/12901#issuecomment-1317954582
>
so the plan for now is to return empty data list when fetching resource list in task definition (task modal). What about landing on the resource center? which one would you prefer @SbloodyS @Radeity?
I personally think behaviours for such cases should be same, in other words, empty list should be returned when landing on resource center without having a tenant resource path created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Radeity commented on issue #12901: [Improvement][Resource Center] Return empty list instead of throwing errors when detecting no path existed for a tenant resource path
Posted by GitBox <gi...@apache.org>.
Radeity commented on issue #12901:
URL: https://github.com/apache/dolphinscheduler/issues/12901#issuecomment-1317948799
> I think simply just return an empty data list is ok since this is only the task instance definition, not the resource center.
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou commented on issue #12901: [Improvement][Resource Center] Return empty list instead of throwing errors when detecting no path existed for a tenant resource path
Posted by GitBox <gi...@apache.org>.
EricPyZhou commented on issue #12901:
URL: https://github.com/apache/dolphinscheduler/issues/12901#issuecomment-1315528330
Based on opinions in the community, we actually have 2 options regarding this issue:
1. Do NOT throw an error. Instead, we return empty data lists.
2. Improve error messages for circumstances including:
a. Resource Storage does not start up
b. A tenant resource path is not found in Resource Storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org