[GitHub] [ozone] ChenSammi commented on a diff in pull request #3843: HDDS-7182. Add property to control RocksDB max open files

[GitBox <gi...@apache.org>]

ChenSammi commented on code in PR #3843:
URL: https://github.com/apache/ozone/pull/3843#discussion_r997667304


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -338,16 +340,24 @@ public void setWaitOnAllFollowers(boolean val) {
   )
   private int rocksdbMaxFileNum = ROCKSDB_LOG_MAX_FILE_NUM_DEFAULT;
 
-  @Config(key = "rocksdb.delete_obsolete_files_period",
-      defaultValue = "6h", timeUnit = MICROSECONDS,
+  @Config(key = "rocksdb.delete-obsolete-files-period",

Review Comment:
   The main purpose of Replacing _ with - is to be consistent with other rocksdb property name style. The property is a recently added, should not introduce any compatibility issue. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org