[GitHub] [pulsar] sijie commented on a change in pull request #8365: [Go functions] Provide pre-start access to secrets and conf

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #8365:
URL: https://github.com/apache/pulsar/pull/8365#discussion_r512854054



##########
File path: pulsar-function-go/pf/context.go
##########
@@ -119,6 +118,15 @@ func (c *FunctionContext) GetUserConfMap() map[string]interface{} {
 	return c.userConfigs
 }
 
+func (c *FunctionContext) GetSecretsMap() map[string]interface{} {

Review comment:
       I don't think it is a good idea to pass `secrets` in plain text. In Java & Python functions, we have introduced a notion called a secrets provider. The secrets provider is responsible for retrieving secrets for functions. 
   
   I'd suggest moving the secrets change to a separate pull request. Because it requires a fair amount of work to get a good implementation with a secrets provider. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org