[GitHub] [superset] michael-s-molina commented on a diff in pull request #24550: fix: Deque mutated during iteration

["michael-s-molina (via GitHub)" <gi...@apache.org>]

michael-s-molina commented on code in PR #24550:
URL: https://github.com/apache/superset/pull/24550#discussion_r1246672041


##########
tests/unit_tests/databases/ssh_tunnel/dao_tests.py:
##########
@@ -35,7 +35,7 @@ def test_create_ssh_tunnel():
         "password": "bar",
     }
 
-    result = SSHTunnelDAO.create(properties)
+    result = SSHTunnelDAO.create(properties, commit=False)

Review Comment:
   @hughhhh I set `commit=False` to mimic the other tests in the `ssh_tunnel/commands` folder which use `CreateSSHTunnelCommand` that has `commit=False` by default. If we enable the commit in this test or in the command ones, they will fail because there's no database with `id = 1`. If an actual commit is required for the tests, I suggest opening a follow-up PR and fixing not only this test but the ones in the `commands` folder.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org