You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bval.apache.org by "Matt Benson (JIRA)" <ji...@apache.org> on 2010/06/28 17:03:02 UTC
[jira] Created: (BVAL-70) Remove @Override annotations from methods
implementing interfaces
Remove @Override annotations from methods implementing interfaces
-----------------------------------------------------------------
Key: BVAL-70
URL: https://issues.apache.org/jira/browse/BVAL-70
Project: BeanValidation
Issue Type: Improvement
Components: jsr303
Affects Versions: 0.2-incubating
Reporter: Matt Benson
Priority: Trivial
The source level of the bval project as a whole is set at 1.5. The best I've been able to determine, 1.6 permits these annotations but 1.5 does not. In particular, Eclipse complains about these, but again, my research seems to bear it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BVAL-70) Remove @Override annotations from methods
implementing interfaces
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods updated BVAL-70:
-----------------------------
Issue Type: Bug (was: Improvement)
Priority: Critical (was: Trivial)
> Remove @Override annotations from methods implementing interfaces
> -----------------------------------------------------------------
>
> Key: BVAL-70
> URL: https://issues.apache.org/jira/browse/BVAL-70
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.2-incubating
> Reporter: Matt Benson
> Assignee: Donald Woods
> Priority: Critical
> Attachments: overrides.patch.txt
>
>
> The source level of the bval project as a whole is set at 1.5. The best I've been able to determine, 1.6 permits these annotations but 1.5 does not. In particular, Eclipse complains about these, but again, my research seems to bear it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BVAL-70) Remove @Override annotations from
methods implementing interfaces
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883667#action_12883667 ]
Donald Woods commented on BVAL-70:
----------------------------------
OK, this also bombs with the latest 1.5.0_24 on MacOSX 10.5 and I found several references to the fact that @Override cannot be used on methods from Interface classes in 1.5.0, but it supported in 1.6.
So, I'm going to comment out the offending @Override usage, so the builds will run again with 1.5.0.
> Remove @Override annotations from methods implementing interfaces
> -----------------------------------------------------------------
>
> Key: BVAL-70
> URL: https://issues.apache.org/jira/browse/BVAL-70
> Project: BeanValidation
> Issue Type: Improvement
> Components: jsr303
> Affects Versions: 0.2-incubating
> Reporter: Matt Benson
> Assignee: Donald Woods
> Priority: Trivial
> Attachments: overrides.patch.txt
>
>
> The source level of the bval project as a whole is set at 1.5. The best I've been able to determine, 1.6 permits these annotations but 1.5 does not. In particular, Eclipse complains about these, but again, my research seems to bear it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (BVAL-70) Remove @Override annotations from
methods implementing interfaces
Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Benson reopened BVAL-70:
-----------------------------
Violated again in r960471.
> Remove @Override annotations from methods implementing interfaces
> -----------------------------------------------------------------
>
> Key: BVAL-70
> URL: https://issues.apache.org/jira/browse/BVAL-70
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.2-incubating
> Reporter: Matt Benson
> Assignee: Donald Woods
> Priority: Critical
> Attachments: overrides.patch.txt
>
>
> The source level of the bval project as a whole is set at 1.5. The best I've been able to determine, 1.6 permits these annotations but 1.5 does not. In particular, Eclipse complains about these, but again, my research seems to bear it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BVAL-70) Remove @Override annotations from
methods implementing interfaces
Posted by "Carlos Vara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885647#action_12885647 ]
Carlos Vara commented on BVAL-70:
---------------------------------
Aww, my fault, I mixed the patch in that revision with some code I had for BVAL-73, I fix it in a sec.
Thanks a lot for reviewing it Matt.
> Remove @Override annotations from methods implementing interfaces
> -----------------------------------------------------------------
>
> Key: BVAL-70
> URL: https://issues.apache.org/jira/browse/BVAL-70
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.2-incubating
> Reporter: Matt Benson
> Assignee: Donald Woods
> Priority: Critical
> Attachments: override-again.patch.txt, overrides.patch.txt
>
>
> The source level of the bval project as a whole is set at 1.5. The best I've been able to determine, 1.6 permits these annotations but 1.5 does not. In particular, Eclipse complains about these, but again, my research seems to bear it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BVAL-70) Remove @Override annotations from methods
implementing interfaces
Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Benson updated BVAL-70:
----------------------------
Attachment: override-again.patch.txt
> Remove @Override annotations from methods implementing interfaces
> -----------------------------------------------------------------
>
> Key: BVAL-70
> URL: https://issues.apache.org/jira/browse/BVAL-70
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.2-incubating
> Reporter: Matt Benson
> Assignee: Donald Woods
> Priority: Critical
> Attachments: override-again.patch.txt, overrides.patch.txt
>
>
> The source level of the bval project as a whole is set at 1.5. The best I've been able to determine, 1.6 permits these annotations but 1.5 does not. In particular, Eclipse complains about these, but again, my research seems to bear it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BVAL-70) Remove @Override annotations from
methods implementing interfaces
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883213#action_12883213 ]
David Jencks commented on BVAL-70:
----------------------------------
I like these @Overrides. Would if be possible to either decide java 1.6 is the minimum supported version or use 1.6 for source and 1.5 for target?
> Remove @Override annotations from methods implementing interfaces
> -----------------------------------------------------------------
>
> Key: BVAL-70
> URL: https://issues.apache.org/jira/browse/BVAL-70
> Project: BeanValidation
> Issue Type: Improvement
> Components: jsr303
> Affects Versions: 0.2-incubating
> Reporter: Matt Benson
> Priority: Trivial
> Attachments: overrides.patch.txt
>
>
> The source level of the bval project as a whole is set at 1.5. The best I've been able to determine, 1.6 permits these annotations but 1.5 does not. In particular, Eclipse complains about these, but again, my research seems to bear it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BVAL-70) Remove @Override annotations from
methods implementing interfaces
Posted by "Carlos Vara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Vara resolved BVAL-70.
-----------------------------
Fix Version/s: 0.2-incubating
Resolution: Fixed
Merged 2nd patch. Not the mixture I thought, but still my fault. I'm definitely including a jdk1.5 test build in my process to avoid this from happening again.
> Remove @Override annotations from methods implementing interfaces
> -----------------------------------------------------------------
>
> Key: BVAL-70
> URL: https://issues.apache.org/jira/browse/BVAL-70
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.2-incubating
> Reporter: Matt Benson
> Assignee: Donald Woods
> Priority: Critical
> Fix For: 0.2-incubating
>
> Attachments: override-again.patch.txt, overrides.patch.txt
>
>
> The source level of the bval project as a whole is set at 1.5. The best I've been able to determine, 1.6 permits these annotations but 1.5 does not. In particular, Eclipse complains about these, but again, my research seems to bear it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BVAL-70) Remove @Override annotations from
methods implementing interfaces
Posted by "Carlos Vara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883729#action_12883729 ]
Carlos Vara commented on BVAL-70:
---------------------------------
Just for the record, I retested the build with the old sources in linux with jdk1.5.0_21 and got the same set of errors. I somehow didn't set my environment right the first time. Sorry for the misinformation.
> Remove @Override annotations from methods implementing interfaces
> -----------------------------------------------------------------
>
> Key: BVAL-70
> URL: https://issues.apache.org/jira/browse/BVAL-70
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.2-incubating
> Reporter: Matt Benson
> Assignee: Donald Woods
> Priority: Critical
> Attachments: overrides.patch.txt
>
>
> The source level of the bval project as a whole is set at 1.5. The best I've been able to determine, 1.6 permits these annotations but 1.5 does not. In particular, Eclipse complains about these, but again, my research seems to bear it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BVAL-70) Remove @Override annotations from
methods implementing interfaces
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods resolved BVAL-70.
------------------------------
Resolution: Fixed
Verified patched code can be built with 1.5.0_24 and 1.6.0_20 on MacOSX.
> Remove @Override annotations from methods implementing interfaces
> -----------------------------------------------------------------
>
> Key: BVAL-70
> URL: https://issues.apache.org/jira/browse/BVAL-70
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.2-incubating
> Reporter: Matt Benson
> Assignee: Donald Woods
> Priority: Critical
> Attachments: overrides.patch.txt
>
>
> The source level of the bval project as a whole is set at 1.5. The best I've been able to determine, 1.6 permits these annotations but 1.5 does not. In particular, Eclipse complains about these, but again, my research seems to bear it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BVAL-70) Remove @Override annotations from
methods implementing interfaces
Posted by "Carlos Vara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883263#action_12883263 ]
Carlos Vara commented on BVAL-70:
---------------------------------
I did a test build using jdk1.5.0_21 and got no errors on compilation, so maybe latest versions of the 1.5 JDK only output a warning on these cases?
I'd also prefer to keep them as they add a useful compile time check.
> Remove @Override annotations from methods implementing interfaces
> -----------------------------------------------------------------
>
> Key: BVAL-70
> URL: https://issues.apache.org/jira/browse/BVAL-70
> Project: BeanValidation
> Issue Type: Improvement
> Components: jsr303
> Affects Versions: 0.2-incubating
> Reporter: Matt Benson
> Priority: Trivial
> Attachments: overrides.patch.txt
>
>
> The source level of the bval project as a whole is set at 1.5. The best I've been able to determine, 1.6 permits these annotations but 1.5 does not. In particular, Eclipse complains about these, but again, my research seems to bear it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BVAL-70) Remove @Override annotations from methods
implementing interfaces
Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Benson updated BVAL-70:
----------------------------
Attachment: overrides.patch.txt
relative to /bval
> Remove @Override annotations from methods implementing interfaces
> -----------------------------------------------------------------
>
> Key: BVAL-70
> URL: https://issues.apache.org/jira/browse/BVAL-70
> Project: BeanValidation
> Issue Type: Improvement
> Components: jsr303
> Affects Versions: 0.2-incubating
> Reporter: Matt Benson
> Priority: Trivial
> Attachments: overrides.patch.txt
>
>
> The source level of the bval project as a whole is set at 1.5. The best I've been able to determine, 1.6 permits these annotations but 1.5 does not. In particular, Eclipse complains about these, but again, my research seems to bear it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (BVAL-70) Remove @Override annotations from
methods implementing interfaces
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods reassigned BVAL-70:
--------------------------------
Assignee: Donald Woods
> Remove @Override annotations from methods implementing interfaces
> -----------------------------------------------------------------
>
> Key: BVAL-70
> URL: https://issues.apache.org/jira/browse/BVAL-70
> Project: BeanValidation
> Issue Type: Improvement
> Components: jsr303
> Affects Versions: 0.2-incubating
> Reporter: Matt Benson
> Assignee: Donald Woods
> Priority: Trivial
> Attachments: overrides.patch.txt
>
>
> The source level of the bval project as a whole is set at 1.5. The best I've been able to determine, 1.6 permits these annotations but 1.5 does not. In particular, Eclipse complains about these, but again, my research seems to bear it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BVAL-70) Remove @Override annotations from
methods implementing interfaces
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883242#action_12883242 ]
Donald Woods commented on BVAL-70:
----------------------------------
I'd prefer David's suggestion, as I'm only using Java SE 6 on MacOSX and think keeping @Overrides improves the code readability....
> Remove @Override annotations from methods implementing interfaces
> -----------------------------------------------------------------
>
> Key: BVAL-70
> URL: https://issues.apache.org/jira/browse/BVAL-70
> Project: BeanValidation
> Issue Type: Improvement
> Components: jsr303
> Affects Versions: 0.2-incubating
> Reporter: Matt Benson
> Priority: Trivial
> Attachments: overrides.patch.txt
>
>
> The source level of the bval project as a whole is set at 1.5. The best I've been able to determine, 1.6 permits these annotations but 1.5 does not. In particular, Eclipse complains about these, but again, my research seems to bear it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BVAL-70) Remove @Override annotations from
methods implementing interfaces
Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883276#action_12883276 ]
Matt Benson commented on BVAL-70:
---------------------------------
In light of all this infromation, I suppose you can close as INVALID. I'll just use my local patch until I am able to upgrade to Eclipse 3.6, which is reported as no longer showing an error when a method declared in an interface (rather than a superclass) is annotated with @Override.
Thanks all,
Matt
> Remove @Override annotations from methods implementing interfaces
> -----------------------------------------------------------------
>
> Key: BVAL-70
> URL: https://issues.apache.org/jira/browse/BVAL-70
> Project: BeanValidation
> Issue Type: Improvement
> Components: jsr303
> Affects Versions: 0.2-incubating
> Reporter: Matt Benson
> Priority: Trivial
> Attachments: overrides.patch.txt
>
>
> The source level of the bval project as a whole is set at 1.5. The best I've been able to determine, 1.6 permits these annotations but 1.5 does not. In particular, Eclipse complains about these, but again, my research seems to bear it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.