[GitHub] [spark] cloud-fan commented on a change in pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #29032:
URL: https://github.com/apache/spark/pull/29032#discussion_r455235801



##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
##########
@@ -912,7 +912,8 @@ private[spark] class TaskSchedulerImpl(
     }
   }
 
-  override def executorDecommission(executorId: String): Unit = {
+  override def executorDecommission(executorId: String,

Review comment:
       nit: code style should be
   ```
   override def ...(
       para1: T, para2: T): ... 
   ```
   
   4 space indentation for the parameter list.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org